Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace dark theme #524

Merged
merged 19 commits into from
Nov 4, 2024
Merged

Replace dark theme #524

merged 19 commits into from
Nov 4, 2024

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Oct 31, 2024

Motivation

Update the dark theme.

Demo: https://qsgjb-riaaa-aaaaa-aaaga-cai.mstr-ingress.devenv.dfinity.network/ (+blue icons update)

Changes

  1. Added new color that is needed for the new theme.
  2. Copied CSS variables from the dark theme to the light theme to address any missing variables in the light theme. To not introduce any light theme changes after color replacement in the dark theme.
  3. Replaced colors in the dark theme with new values. Color mapping was done using another branch as a color source, where designers verified the new new theme colors. Using this script and manual adjustment not covered by the script entries (mainly hex-to-RGB conversions).

Screenshots

image image

@mstrasinskis mstrasinskis marked this pull request as ready for review October 31, 2024 16:22
@mstrasinskis mstrasinskis requested review from a team as code owners October 31, 2024 16:22
src/lib/styles/global/colors.scss Outdated Show resolved Hide resolved
src/lib/styles/themes/light.scss Outdated Show resolved Hide resolved
src/lib/styles/themes/dark.scss Show resolved Hide resolved
@mstrasinskis mstrasinskis merged commit 4727620 into main Nov 4, 2024
9 checks passed
@mstrasinskis mstrasinskis deleted the replace-dark-theme branch November 4, 2024 17:18
mstrasinskis added a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants