Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio toggle component #387

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Radio toggle component #387

wants to merge 12 commits into from

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Feb 26, 2024

Motivation

A radio group component to be used first on the proposals page.

Changes

  • RadioToggle compoent

Test

  • RadioToggle

Screenshots

image image

@mstrasinskis mstrasinskis changed the title WIP Radio toggle component Radio toggle component Feb 27, 2024
@mstrasinskis mstrasinskis marked this pull request as ready for review February 27, 2024 13:47
@dskloetd
Copy link
Collaborator

Can we perhaps use Segment and SegmentButton, like we use here to switch between ckBTC and Bitcoin on the receive modal?

image

@mstrasinskis
Copy link
Contributor Author

mstrasinskis commented Feb 27, 2024

Can we perhaps use Segment and SegmentButton, like we use here to switch between ckBTC and Bitcoin on the receive modal?

Perhaps we could, but this means to support 2 different themes for the component with different styles / widths.

image image

Let me evaluate it.

@dskloetd
Copy link
Collaborator

I think we should be careful about adding new design elements every time we add a new feature and try to reuse components as much as possible. Would be could if you could check with PM/UX if this can be reused. Maybe by adjusting either the existing component or the new feature. Thanks!

@mstrasinskis mstrasinskis marked this pull request as draft February 29, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants