-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow worker arguments of any type #95
Comments
For instance, it's handy to use make dialyze
Checking whether the PLT /Users/aenesterov/projects/github/riak-connection-pool/.riakc_pool.plt is up-to-date... yes
Proceeding with analysis...
riakc_pool_conn.erl:37: The specified type for the 1st argument of start_link/1 (map()) is not a supertype of [atom() | tuple()], which is expected type for this argument in the callback of the poolboy_worker behaviour
riakc_pool_conn.erl:38: The inferred type for the 1st argument of start_link/1 (#{'host':=maybe_improper_list(), 'port':=pos_integer(), _=>_}) is not a supertype of [atom() | tuple()], which is expected type for this argument in the callback of the poolboy_worker behaviour
Unknown types:
ssl:sslsocket/0
done in 0m1.25s
done (warnings were emitted)
make: *** [dialyze] Error 2 |
@devinus what do you think on that matter? |
rlipscombe
added a commit
to rlipscombe/poolboy
that referenced
this issue
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is no sense to restrict worker arguments to proplists. While they are opaque to poolboy and are passed as is, they could be anything.
The text was updated successfully, but these errors were encountered: