Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the Storage to the Deveel.Repository #50

Closed
tsutomi opened this issue Oct 13, 2023 · 0 comments · Fixed by #52
Closed

Migrate the Storage to the Deveel.Repository #50

tsutomi opened this issue Oct 13, 2023 · 0 comments · Fixed by #52
Assignees
Labels
enhancement New feature or request service Webhook Service management

Comments

@tsutomi
Copy link
Member

tsutomi commented Oct 13, 2023

The current implementation of the Webhook Subscription Management feature uses a storage model that is based on an internet contract, based on the Repository pattern (IWebhookSubscriptionStore).

Deveel has recently released the Deveel.Repository project, implementing all the functions for the management of the WebhookSubscription and WebhookDeliveryResult entities.

Expected Benefits

Replacing the existing storage model with the one provided by Deveel.Repository would introduce the best practices and methods provided externally, unifying the development and maintenance efforts for both projects.

Adopting the Deveel.Repository as the model for the management of stores will also align the multi-tenant database management.

Possible Side Effects

The Deveel.Repository project has not been used (at the moment of this issue, 10/13/2023) by external projects that would extend its base CRUD functions, and at its possible that the migration will cause some incompatibilities.

@tsutomi tsutomi added enhancement New feature or request service Webhook Service management labels Oct 13, 2023
@tsutomi tsutomi self-assigned this Oct 20, 2023
@tsutomi tsutomi linked a pull request Oct 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request service Webhook Service management
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant