Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Slug for Session URL #272

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

jenslauterbach
Copy link
Contributor

@jenslauterbach jenslauterbach commented Nov 20, 2021

Minor update to the existing code for the session list. The only real
change is that the "id" is now the slug of the Talk and the "url" uses
the talks slug instead of the pk.

Further improvements will be made to the serializer, once the other
endpoints/serializers are done.

The output of /api/sessions looks now like this:

[
    {
        "id": "acheing-a-internally-attached-limit",
        "url": "http://localhost:8000/api/sessions/acheing-a-internally-attached-limit/",
        "title": "Acheing A Internally Attached Limit",
        "description": "Magnam tempora sit quaerat sit amet. Dolorem ut quiquia magnam quisquam. Consectetur sit consectetur tempora est amet. Voluptatem sed dolor voluptatem sed adipisci porro. Adipisci neque non velit dolorem. Quaerat ipsum dolore adipisci sit labore consectetur quisquam.",
        "published_speakers": [
            "Jana Vogel (devdata.18)"
        ],
        "event": "devdata.18"
    },
    {
        "id": "affirming-a-wetly-querulous-bill",
        "url": "http://localhost:8000/api/sessions/affirming-a-wetly-querulous-bill/",
        "title": "Affirming A Wetly Querulous Bill",
        "description": "Sit modi etincidunt voluptatem. Dolor est magnam neque consectetur sed est tempora. Sit dolorem aliquam modi. Voluptatem amet ipsum sed sed voluptatem sed. Dolorem etincidunt ut modi dolore velit. Consectetur tempora ipsum voluptatem dolore adipisci tempora ipsum. Eius sed modi non adipisci adipisci dolorem neque. Ipsum adipisci dolorem ut quisquam eius. Amet etincidunt aliquam non neque.",
        "published_speakers": [
            "Natalie Lehmann (devdata.17)"
        ],
        "event": "devdata.17"
    }
]

Part of issue #220

Minor update to the existing code for the session list. The only real
change is that the "id" is now the slug of the Talk and the "url" uses
the talks slug instead of the pk.

Further improvements will be made to the serializer, once the other
endpoints/serializers are done.
@jenslauterbach jenslauterbach self-assigned this Nov 20, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1485004250

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 99.629%

Totals Coverage Status
Change from base Build 1285790417: 0.07%
Covered Lines: 3755
Relevant Lines: 3770

💛 - Coveralls

@jenslauterbach jenslauterbach requested a review from jandd November 21, 2021 17:35
@jandd jandd merged commit a13cf52 into devdaydresden:development Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants