Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use youtube-nocookie.com for video embedding #237

Open
jandd opened this issue Feb 7, 2020 · 2 comments
Open

Use youtube-nocookie.com for video embedding #237

jandd opened this issue Feb 7, 2020 · 2 comments
Assignees
Labels
frontend Design, HTML, CSS, JS
Milestone

Comments

@jandd
Copy link
Contributor

jandd commented Feb 7, 2020

Is your feature request related to a problem? Please describe.
The current video plugin embeds videos from the main youtube.com domain which is setting several cookies. Youtube provides a second domain youtube-nocookie.com that does not set cookies. Using that second domain would improve our user's privacy.

Describe the solution you'd like
The djangocms_video plugin should support the nocookie domain.

Additional context
I created a PR to implement this feature at django-cms/djangocms-video#56

@jandd jandd self-assigned this Feb 7, 2020
@jandd jandd added the frontend Design, HTML, CSS, JS label Feb 7, 2020
@jandd jandd added this to the DevDay 2020 milestone Feb 7, 2020
@jenslauterbach
Copy link
Contributor

Are we really using this plugin? At least our user facing page uses a "normal" template with a hardcoded youtube url.

See: https://github.com/devdaydresden/devday_website/blob/development/devday/talk/templates/talk/talk_details.html#L46

Am I missing something? Shall I fix this part of the code to use the nocookie-domain?

@jandd
Copy link
Contributor Author

jandd commented Mar 9, 2020

The code in the talk pages could be fixed indeed. The plugin is used in CMS pages i.e. our front page currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Design, HTML, CSS, JS
Projects
None yet
Development

No branches or pull requests

2 participants