Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an error state #34

Open
arpit-saxena opened this issue Jul 17, 2020 · 0 comments
Open

Make an error state #34

arpit-saxena opened this issue Jul 17, 2020 · 0 comments
Assignees

Comments

@arpit-saxena
Copy link
Member

When an unexpected thing happens during deployment, the service should be put in an error state which can be manually stopped. We can't leave the state as Deploying since no operation would then be able to work on it.

Needed here:

// There should be no error here, ever. Checking it to make sure
// TODO: On error, set state to an "error" state which only stop should be able to modify
tag, err1 = history.SetState(a.RepoURL, tag, state)
for ; err1 != nil; tag, err1 = history.SetState(a.RepoURL, tag, state) {
log.Errorf("setting state to %v failed - %v. Retrying...", state.Status, err1)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant