Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Dockerising the application #93

Open
verma-kunal opened this issue Oct 11, 2022 · 5 comments · May be fixed by #95
Open

[Feature] Dockerising the application #93

verma-kunal opened this issue Oct 11, 2022 · 5 comments · May be fixed by #95
Assignees

Comments

@verma-kunal
Copy link

Is your feature request related to a problem? Please describe.
N/A

Describe the solution you'd like
I am proposing to create a Dockerfile which would enable users to run this application in a containerised environment, using Docker.

Describe alternatives you've considered
N/A

Additional context
N/A

@devansh016
Copy link
Owner

okay. You can go ahead. @verma-kunal

@verma-kunal
Copy link
Author

verma-kunal commented Oct 18, 2022

Hey @devansh016 , from README i can see that we'll have to set up environment variables! Would we have to create an .env file for that?
I am a bit caught up at this point, but was able to setup the application locally

@verma-kunal
Copy link
Author

Hey @devansh016 , the docker file has been created.
The main issue I am facing right now is that, when we run the app, a new file is being created called newsArticles.txt.
Now, when we run the docker container for the same, this new file is not being recognised by the container or not being created!

Here is the error log:
Screenshot 2022-10-25 at 3 52 59 PM

Have to search a bit on this, but would like to know your thoughts as well

@verma-kunal
Copy link
Author

Hey @devansh016 , i was able to solve this particular issue & now the app is running on the container!

Although, the content isn't visible on the site & I believe thats an issue with the API.
Screenshot 2022-10-25 at 5 02 47 PM

@verma-kunal
Copy link
Author

I can make a PR for the dockerfile and then maybe we can work on this api issue

@verma-kunal verma-kunal linked a pull request Oct 25, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants