From 21f79b07f90be0711b1338062fa240e73c510d30 Mon Sep 17 00:00:00 2001 From: Dominik Wilkowski Date: Fri, 13 Aug 2021 11:47:32 +1000 Subject: [PATCH 1/2] Added RFC for separating framework entry points --- RFCs/1-approved/separate-components.md | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 RFCs/1-approved/separate-components.md diff --git a/RFCs/1-approved/separate-components.md b/RFCs/1-approved/separate-components.md new file mode 100644 index 0000000..ccb0882 --- /dev/null +++ b/RFCs/1-approved/separate-components.md @@ -0,0 +1,20 @@ +--- +Status: `Proposal` # Please do not change this. +Implementer: # It will be changed upon merging and as it moves through the RFC stages +--- + +# Separate components between React, jQuery and Vanilla + +## The issue to be solved + +We currently share a lot of code between the vanilla, jQuery and React components. +This has led to a bunch of issues including the fact that we're not using each framework to its fullest potential. + +## A short description of the solution + +I propose we create separate entry-points for each language and maintain a separation for the JavaScript used in each. +We should still re-use the same CSS though or aim to at least use the same token base (which isn't insufficiently separated yet either). + +## Technical details + +TODO 😬 From ed21618ee57d9a7929f5e4aff056f154e9187d1d Mon Sep 17 00:00:00 2001 From: Dominik Wilkowski Date: Tue, 14 Dec 2021 14:24:58 +1100 Subject: [PATCH 2/2] finished RFC --- RFC-by-stage/1-approved/separate-components.md | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/RFC-by-stage/1-approved/separate-components.md b/RFC-by-stage/1-approved/separate-components.md index ccb0882..5df4c88 100644 --- a/RFC-by-stage/1-approved/separate-components.md +++ b/RFC-by-stage/1-approved/separate-components.md @@ -17,4 +17,20 @@ We should still re-use the same CSS though or aim to at least use the same token ## Technical details -TODO 😬 +The implementation would be split in separate entry points. +So inside the monorepo we would have a structure like this: + +```sh +. +└── packages + ├── react + │ └── ... (a folder per component that is supported in react) + ├── jquery + │ └── ... (a folder per component that is supported in jquery) + └── vanilla + └── ... (a folder per component that is supported in vanilla) +``` + +This will make it easier to make changes to each entry-point. + +we will work to re-use the tokens wherever we can and since the workspaces are visible to each other this should be simple enough.