Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell execution timer continues even after kernel is shutdown #117

Open
mbektas opened this issue Apr 2, 2024 · 2 comments
Open

Cell execution timer continues even after kernel is shutdown #117

mbektas opened this issue Apr 2, 2024 · 2 comments
Assignees

Comments

@mbektas
Copy link

mbektas commented Apr 2, 2024

Steps to reproduce:

  1. Run a notebook cell which takes long to execute
  2. Close and reopen the notebook
  3. Notice that the timer still ticks, even if kernel is shut down after reopening.

I would expect timer to not tick after reopening the notebook.

cell execution timer

@krassowski
Copy link
Collaborator

While it is easy to solve for the case of a dead kernel, in general if kernel is still running when re-opening we would not know if any given cell has already completed execution. We are exploring something to fix that in jupyter-server/jupyter_server#990 (comment)

@krassowski krassowski self-assigned this Apr 2, 2024
@krassowski
Copy link
Collaborator

I looked a bit more into this and because the timer is a function of cell metadata, even a hot fix would not be trivial (unless we store kernel/session ID in the cell metadata which would be rather noisy; this way we could compare if the currently running kernel - if any - is the kernel in which the cell execution started). Again, it looks like the best solution would be adopting jupyter-server/jupyter_server#990 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants