Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High sample count crashes IBLBaker #12

Open
remcohuijser opened this issue Nov 8, 2018 · 7 comments
Open

High sample count crashes IBLBaker #12

remcohuijser opened this issue Nov 8, 2018 · 7 comments

Comments

@remcohuijser
Copy link

When you choose a high number of samples (anything higher than 512) IBLBaker stops. In debug there is no exception given.

@remcohuijser
Copy link
Author

I tried to disconnect the sample count from the samples per frame so that the samples are spread out over a number of frames. This seems to work as IBLBaker takes a couple of frames to calculate the end result and you can actually see the intermediate result being updated.

I did notice something strange though: it appears that the result from the previous pass are not correctly combined with the next pass. As a result result becomes 'smeared' along the edges (see image below):
image

Because of this, the resulting map is not usable :(

@derkreature
Copy link
Owner

Yeah, I imagine there is a bug in offsetting the sample Id in regards to hammersley point generation. I’ll take a look.

@derkreature
Copy link
Owner

Are you just hitting TDR timeouts?

@remcohuijser
Copy link
Author

I am not sure to be honest. Any way I can check?

@derkreature
Copy link
Owner

I’ll take a look at this over the holiday break.

@remcohuijser
Copy link
Author

Much appreciated!

@derkreature
Copy link
Owner

I am getting to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants