This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Niloofar / Dropdown implementations #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloofar-deriv
commented
Oct 12, 2023
niloofar-deriv
commented
Oct 12, 2023
hasan-deriv
reviewed
Oct 12, 2023
hasan-deriv
reviewed
Oct 12, 2023
mayuran-deriv
approved these changes
Oct 12, 2023
nada-deriv
approved these changes
Oct 17, 2023
niloofar-deriv
force-pushed
the
niloo/86bw351qv/dropdown
branch
from
12749aa to
75426dd
Compare
niloofar-deriv
commented
Oct 18, 2023
| @@ -1,3 +0,0 @@ | |||
| const Button = () => <div>button</div>; | |||
There was a problem hiding this comment.
We don't need button, modal and dropdown components in the common folder cause we have them inside the ui folder.
So I removed these extra files.
niloofar-deriv
commented
Oct 18, 2023
| @@ -1,7 +1,15 @@ | |||
| import { describe, expect, it } from 'vitest'; | |||
| import { render, screen } from '@testing-library/react'; | |||
| import userEvent from '@testing-library/user-event'; | |||
There was a problem hiding this comment.
Moved the test file to the __test__ folder!
niloofar-deriv
commented
Oct 18, 2023
| @@ -1,21 +0,0 @@ | |||
| // Button.stories.ts|tsx | |||
There was a problem hiding this comment.
This story was written for the old button component so I removed that
niloofar-deriv
commented
Oct 18, 2023
| @@ -0,0 +1,75 @@ | |||
| import { forwardRef, ElementRef, ComponentPropsWithoutRef } from 'react'; | |||
There was a problem hiding this comment.
Auto generated component
niloofar-deriv
commented
Oct 18, 2023
| const DropdownMenuPortal = Portal; | ||
| const DropdownMenuSub = Sub; | ||
| const DropdownMenuRadioGroup = RadioGroup; | ||
|
|
There was a problem hiding this comment.
Since we don't have a common drop-down style I removed all of the classnames, later when we want to use this we can pass the classes to it!
niloofar-deriv
requested review from
hasan-deriv,
nada-deriv and
mayuran-deriv
nada-deriv
reviewed
Oct 18, 2023
mayuran-deriv
approved these changes
Oct 19, 2023
matin-deriv
approved these changes
Oct 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes our global dropdown component!