Patch redirect page language #876
Merged
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienne-deriv
temporarily deployed
to
Development
GitHub Actions
Inactive
|
Preview Link: https://pr-876.smarttrader-preview.pages.dev
|
adrienne-deriv
commented
Dec 10, 2024
| @@ -656,9 +656,10 @@ const Header = (() => { | |||
| const isOAuth2Enabled = AuthClient.isOAuth2Enabled(); | |||
|
|
|||
| if (isOAuth2Enabled) { | |||
| const redirectCallbackUri = `${window.location.origin}/en/callback`; | |||
| const currentLanguage = Language.get(); | |||
There was a problem hiding this comment.
This should already have default fallback to EN in the function:
adrienne-deriv
commented
Dec 10, 2024
| const postLoginRedirectUri = window.location.origin; | ||
| const postLogoutRedirectUri = `${window.location.origin}/en/trading`; | ||
| const postLogoutRedirectUri = `${window.location.origin}/${currentLanguage}/trading`; | ||
| // Test commit |
There was a problem hiding this comment.
Tested for ru and cn_tw language:
Screen.Recording.2024-12-10.at.2.40.50.PM.mov
Screen.Recording.2024-12-10.at.2.42.33.PM.mov
ahmadtaimoor-deriv
approved these changes
Dec 10, 2024
amam-deriv
approved these changes
Dec 10, 2024
matin-deriv
added a commit
that referenced
this pull request
Dec 10, 2024
Revert: Patch redirect page language #876
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Type of change