-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SmartTrader Redesign #660
SmartTrader Redesign #660
Conversation
Dependency ReviewThe following issues were found:
License Issuespackage-lock.json
package.json
OpenSSF ScorecardScorecard details
Scanned Manifest Filespackage-lock.json
package.json
|
* chore: implemented quill in bottom tabs * chore: undo render.js changes * chore: add event triggers * fix: initial object data * fix: added localize in tabs * fix: removed object key mapping * fix: added parse for localized * fix: removed invisible class for image * fix: fixed eslint errors * fix: added escape character for using double quotes * fix: moved localize to data file * chore: fix translation issues * fix: removed backslash and added localize fot titles under explain * fix: removed extra spaces * fix: add eslint comment for unused var * fix: test issues * fix: fixed conflicts * fix: fixed conflict * fix: tab change reload chart * chore: refactor handling selected contract * fix: added selected tab in session storage and refactored code * fix: added market change for explanation * chore: variable improvement --------- Co-authored-by: prince-deriv <[email protected]>
* chore: draft market dropdown container * chore: undo unnecessary change * chore: undo unnecessary change * chore: undo unnecessary change * chore: undo unnecessary change * chore: undo unnecessary change * chore: no sticky * chore: fully working UI * chore: clean and fix errors * chore: fix onboarding * chore: fix eslint errors * chore: responsive view * chore: added responsive dropdowns * fix: remove unnecessary export * chore: purchase section * chore: long messages content hug * chore: improve market selector * chore: unnecessary change cleanup * fix: onboarding issue * chore: fix ui * fix: eslint errors
* fix: updated dropdown size and added default value * empty: empty commit * fix: fixed sorting issue
* chore: initial trade results dev * chore: results and error messages * chore: popup load * chore: contract end * chore: add login error
* chore: initial trade results dev * chore: results and error messages * chore: popup load * chore: contract end * chore: add login error * chore: hide popup
* fix: updated dropdown size and added default value * empty: empty commit * fix: fixed sorting issue * fix: fixed scroll upward issue * fix: fixed scroll to selected element * fix: updated classname * fix: removed upward scroll fixes
* chore: initial trade results dev * chore: results and error messages * chore: popup load * chore: contract end * chore: add login error * chore: hide popup * chore: ui fixes
* chore: initial trade results dev * chore: results and error messages * chore: popup load * chore: contract end * chore: add login error * chore: hide popup * chore: ui fixes * chore: fix sell and audit clash
* fix: added parser for section msg notes * fix: added parser for texts * fix: removed optional check for data * fix: refactor function * fix: refactor
* chore: initial trade results dev * chore: results and error messages * chore: popup load * chore: contract end * chore: add login error * chore: hide popup * chore: ui fixes * chore: fix sell and audit clash * chore: language fixes * chore: audit and qa test fixes * chore: fixed all around issues
* chore: draft form for stock indices touch/no-touch * chore: rise-and-fall, touch-notouch forms with config * chore: separate form component and fix issues * chore: simplified config and higherlower added * fix: formname condtion for touchnotouch * chore: forms for all the contracts of forex, stock-indices * chore: store start dates in sessionStorage to update the form based on market * chore: update quill-ui * chore: added forms for digits * chore: fix reset css * chore: trade forms until synthetics * chore: trademanager and hook * chore: update starttime, expire type form fields * chore: update old fields based on new selection * chore: remove unused variable * chore: one form for all contracts * chore: data hanlde until exprity type duration fields * chore: setting expirydate in datepicker and update expiry date on change
* fix: startime hasnow condition fixed * fix: remove console logs * fix: empty commit
* chore: initial trade results dev * chore: results and error messages * chore: popup load * chore: contract end * chore: add login error * chore: hide popup * chore: ui fixes * chore: fix sell and audit clash * chore: language fixes * chore: audit and qa test fixes * chore: fixed all around issues * fix: error title
…#692) * fix: market selector not returning to default value when empty search * chore: remove unused code
* fix: last digit tab * fix: removed unused imports * fix: dropdown not being selected properly on digit info * fix: digits chart title * fix: added last digit tab and fixed height * fix: updated quill in explanation and refactored tabs * fix: removed unused vars * fix: refactored tabs * fix: fixed graph on refreshing * fix: updated dropdown size as md * fix: added localize --------- Co-authored-by: prince-deriv <[email protected]>
* fix: footer css breakage after installing quill * chore: remove unused code * fix: purchase section peek text align * chore: add padding fix
* chore: fix all formName dependencies * chore: unused vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check review comments🙏🏻
return ( | ||
<React.Fragment key={sk}> | ||
<DropdownTitle label={name} /> | ||
{Object.keys(symbols).map((yk) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check this suggestion.
*same for sk
above, and ik
at L259 above 🙏🏻
* fix: empty field issues when changing trade * fix: amount empty issue
* fix: digit chart loading * Update src/javascript/app/pages/trade/digit_ticker.js Co-authored-by: Nuzhy-Deriv <[email protected]> * fix: return for arrow function --------- Co-authored-by: Nuzhy-Deriv <[email protected]>
* fix: firefox input type number spin button issue * fix: allow datepicker actionsheet to full height
* fix: all fixable nitpicks * fix: comments * fix: nit
* fix: fixed audit page * fix: refactor * fix: refcactor purchase function * fix: refactor function * fix: refactor purchase function * fix: rename func
…782) * chore: assist with timout cleanups & nit-picks * refactor: 1 more timer cleanup and more nit-picks * fix: more nit-picks
* fix: update formName prop in barrier-fields * fix: translte now in starttime
* fix: updated quill version * fix: changed key name * fix: updated variable name
* fix: pr-nitpicks * fix: undo changes * fix: undo changes
Preview Link: https://pr-660.smarttrader-preview.pages.dev
|
Key Changes:
Focused Refactoring:
Localization and Translation:
Event Emitters: