Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite fails with older perls #47

Open
eserte opened this issue Nov 11, 2023 · 1 comment
Open

Test suite fails with older perls #47

eserte opened this issue Nov 11, 2023 · 1 comment

Comments

@eserte
Copy link

eserte commented Nov 11, 2023

The test suite fails on my smoker systems for older perls (< 5.24). The failures look either like

syntax error at t/onfido.t line 62, near "->%"
Type of arg 1 to Test::Exception::lives_ok must be block or sub {} (not reference constructor) at t/onfido.t line 64, near "'create applicant ok';"
...
# Looks like your test exited with 2 just after 1.
t/onfido.t ............... 
Dubious, test returned 2 (wstat 512, 0x200)
Failed 71/72 subtests 

or like

#   Failed test 'WebService/Async/Onfido.pm loaded ok'
#   at t/00-compile.t line 60.
#          got: '65280'
#     expected: '0'
Indirect call of method "catch" on a block at /home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm line 730.
Indirect call of method "try" on a block at /home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm line 725.
syntax error at /home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm line 689, near "%args{"
syntax error at /home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm line 689, near "} }"
Global symbol "%args" requires explicit package name at /home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm line 691.
...
Global symbol "$self" requires explicit package name at /home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm line 729.
syntax error at /home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm line 736, near "}"
/home/cpansand/.cpan/build/2023111104/WebService-Async-Onfido-0.007-0/blib/lib/WebService/Async/Onfido.pm has too many errors.
Compilation failed in require at -e line 1.
# Looks like you failed 1 test of 17.
t/00-compile.t ........... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/17 subtests 
	(less 2 skipped subtests: 14 okay)

If you don't plan to support older versions than you should probably add a minimum perl version specification.

@eserte
Copy link
Author

eserte commented Nov 11, 2023

Here a good fail/pass overview: http://matrix.cpantesters.org/?dist=WebService-Async-Onfido%200.007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant