Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 [deriv_ui] Imporvements in deriv_ui. #523

Open
2 of 6 tasks
sahani-deriv opened this issue Mar 11, 2024 · 0 comments
Open
2 of 6 tasks

🚀 [deriv_ui] Imporvements in deriv_ui. #523

sahani-deriv opened this issue Mar 11, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@sahani-deriv
Copy link
Contributor

Request Type

  • New Feature in Existing Package
  • New Package Request

Is your feature request related to a problem? Please describe.

  • Expandable bottom sheet has a parameter name 'labelContractDetails' which seems not general and is related to Deriv GO.
  • PopupAlertDialog and CustomAlertDialog are similar except popup alert dialog provides a checkbox content option.
  • Unnecessary dependency to deriv_web_view. Currently web view is only used by buildTextSpanHyperlink . I think its better we make onTap a required parameter and remove webview dependency.
  • Rename context.localisation to context.UiLocalisation or something else as this causes conflicts as client app has the same extension.
  • Primary and secondary button should have default textstyle provided by the package. Currently client apps need to pass their own text style.

Affected Application(s)

  • Deriv Go
  • Deriv P2P
  • Both
  • Not Applicable

Additional context

Add any other context, mockups, diagrams, or code snippets about the feature request here.

@sahani-deriv sahani-deriv added the enhancement New feature or request label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant