From f7ca75ebcf1a4de3f0d4bc724fdcc00d14e810af Mon Sep 17 00:00:00 2001 From: muhammad-ahmed Date: Mon, 14 Oct 2024 16:19:14 +0800 Subject: [PATCH 1/3] ahmed/remove-function-to-fixed-production-release --- .github/workflows/release_production.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release_production.yml b/.github/workflows/release_production.yml index 156817b8..27027c36 100644 --- a/.github/workflows/release_production.yml +++ b/.github/workflows/release_production.yml @@ -95,7 +95,7 @@ jobs: VERCEL_SCOPE: deriv ALIAS_DOMAIN_URL: 'api-docs-dr.binary.sx' - name: Send Slack Notification - if: always() && ${{ steps.publish_to_vercel.outcome != 'success'}} + if: ${{ steps.publish_to_vercel.outcome != 'success'}} uses: ./.github/actions/notify_slack with: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} From 9744d97c8192a18b6925b79d38f46d8ea24e2aa1 Mon Sep 17 00:00:00 2001 From: muhammad-ahmed Date: Mon, 14 Oct 2024 17:52:48 +0800 Subject: [PATCH 2/3] Update action message --- .github/actions/versioning/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/versioning/action.yml b/.github/actions/versioning/action.yml index 2993d55c..524286e3 100644 --- a/.github/actions/versioning/action.yml +++ b/.github/actions/versioning/action.yml @@ -15,5 +15,5 @@ runs: env: RELEASE_TYPE: ${{ inputs.RELEASE_TYPE }} RELEASE_TAG: ${{ inputs.RELEASE_TAG }} - run: echo "$RELEASE_TYPE--GITHUB_REF:$RELEASE_TAG--DATE:$(date -u +'%Y-%m-%dT%H:%M:%SZ')" > build/version.txt + run: echo "$RELEASE_TAG at $(date -u +'%Y-%m-%dT%H:%M:%SZ')" > build/version.txt shell: bash From 47f7109c31ecd46caca67dea5ae59dce4f68a94c Mon Sep 17 00:00:00 2001 From: Muhammad Ahmed Date: Mon, 14 Oct 2024 17:59:04 +0800 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Ali(Ako) Hosseini --- .github/actions/versioning/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/versioning/action.yml b/.github/actions/versioning/action.yml index 524286e3..205c4e45 100644 --- a/.github/actions/versioning/action.yml +++ b/.github/actions/versioning/action.yml @@ -15,5 +15,5 @@ runs: env: RELEASE_TYPE: ${{ inputs.RELEASE_TYPE }} RELEASE_TAG: ${{ inputs.RELEASE_TAG }} - run: echo "$RELEASE_TAG at $(date -u +'%Y-%m-%dT%H:%M:%SZ')" > build/version.txt + run: echo "$RELEASE_TAG" > build/version.txt shell: bash