ahmed/DAPI-774/chore--update-error-handling-app-register

deriv-com · Oct 21, 2024 · bdfb388 · bdfb388
1 parent 3ab30d3
commit bdfb388
Show file tree

Hide file tree

Showing 16 changed files with 102 additions and 790 deletions.
diff --git a/src/features/dashboard/components/Tabs/__tests__/tabs.test.tsx b/src/features/dashboard/components/Tabs/__tests__/tabs.test.tsx
diff --git a/src/features/dashboard/components/Tabs/index.ts b/src/features/dashboard/components/Tabs/index.ts
diff --git a/src/features/dashboard/components/Tabs/tabs.module.scss b/src/features/dashboard/components/Tabs/tabs.module.scss
diff --git a/src/features/dashboard/components/Tabs/tabs.tsx b/src/features/dashboard/components/Tabs/tabs.tsx
diff --git a/...board/components/app-register-success-modal/__tests__/app-register-success-modal.test.tsx b/...board/components/app-register-success-modal/__tests__/app-register-success-modal.test.tsx
@@ -55,10 +55,9 @@ describe('AppRegisterSuccessModal', () => {
     const configure_btn = await screen.findByText(/configure now/i);
     await userEvent.click(configure_btn);
     expect(mock_configure).toHaveBeenCalledTimes(1);
-    expect(mock_cancel).toHaveBeenCalledTimes(1);
 
     const maybe_later_btn = await screen.findByText(/maybe later/i);
     await userEvent.click(maybe_later_btn);
-    expect(mock_cancel).toHaveBeenCalledTimes(2);
+    expect(mock_cancel).toHaveBeenCalledTimes(1);
   });
 });
diff --git a/src/features/dashboard/components/app-register-success-modal/app-register-success-modal.tsx b/src/features/dashboard/components/app-register-success-modal/app-register-success-modal.tsx
@@ -25,12 +25,9 @@ const AppRegisterSuccessModal = ({
     <Modal
       isOpened={app_register_modal_open}
       primaryButtonLabel={translate({ message: 'Configure now' })}
-      primaryButtonCallback={() => {
-        onConfigure();
-        onCancel();
-      }}
+      primaryButtonCallback={() => onConfigure()}
       secondaryButtonLabel={translate({ message: 'Maybe later' })}
-      secondaryButtonCallback={onCancel}
+      secondaryButtonCallback={() => onCancel()}
       isMobile={deviceType !== 'desktop'}
       showHandleBar
       showSecondaryButton