From 1a5e24380aa52e60c11c8e787fcc03599d135250 Mon Sep 17 00:00:00 2001 From: shafin-deriv Date: Thu, 5 Sep 2024 11:22:49 +0800 Subject: [PATCH 1/2] chore: fix github action for DR slack notification failure --- .github/workflows/release_production.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release_production.yml b/.github/workflows/release_production.yml index 5cf2eb166..be8f93f76 100644 --- a/.github/workflows/release_production.yml +++ b/.github/workflows/release_production.yml @@ -93,8 +93,8 @@ jobs: VERCEL_SCOPE: deriv ALIAS_DOMAIN_URL: 'api-docs-dr.binary.sx' - name: Send Slack Notification - if: always() && ${{ steps.publish_to_vercel.outcome != 'success'}} + if: ${{ steps.publish_to_vercel.outcome != 'success'}} uses: ./.github/actions/notify_slack with: - RELEASE_TYPE: ${{ env.RELEASE_TYPE }} + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} MESSAGE: "Publish to vercel failed for '${{ env.RELEASE_TYPE }}' release on api.deriv.com with version *'${{ needs.build_and_publish.outputs.RELEASE_VERSION }}" From 66d6043812aced960bcfc14acc377d0c3407edf9 Mon Sep 17 00:00:00 2001 From: shafin-deriv Date: Thu, 5 Sep 2024 12:15:02 +0800 Subject: [PATCH 2/2] chore: revert back condition --- .github/workflows/release_production.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release_production.yml b/.github/workflows/release_production.yml index be8f93f76..0602cf2bf 100644 --- a/.github/workflows/release_production.yml +++ b/.github/workflows/release_production.yml @@ -93,7 +93,7 @@ jobs: VERCEL_SCOPE: deriv ALIAS_DOMAIN_URL: 'api-docs-dr.binary.sx' - name: Send Slack Notification - if: ${{ steps.publish_to_vercel.outcome != 'success'}} + if: always() && ${{ steps.publish_to_vercel.outcome != 'success'}} uses: ./.github/actions/notify_slack with: SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}