Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install react router 6 in accredited representative portal #33339

Merged
merged 18 commits into from
Dec 10, 2024

Conversation

chumpy
Copy link
Contributor

@chumpy chumpy commented Dec 4, 2024

This is the second step in the react router upgrade path for accredited-representative-portal app. The first step was to isolate the 21a sub-application from any changes from the upgrade. That was done here.

The goal of this step is to perform the upgrade to the accredited-representative-portal application via workspaces.

@chumpy chumpy added the benefits-accredited-rep-facing Label for the OCTO Slack team #benefits-representative-facing label Dec 4, 2024
@chumpy chumpy self-assigned this Dec 4, 2024
@chumpy chumpy force-pushed the art/96895/install-react-router-6 branch from 78377f2 to f76118c Compare December 4, 2024 18:06
@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/install-react-router-6/main December 4, 2024 18:33 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/install-react-router-6/main December 5, 2024 18:10 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/install-react-router-6/main December 5, 2024 19:39 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/install-react-router-6/main December 6, 2024 16:00 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/install-react-router-6/main December 6, 2024 16:45 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/install-react-router-6/main December 6, 2024 18:16 Inactive
@chumpy chumpy marked this pull request as ready for review December 6, 2024 18:18
@chumpy chumpy requested review from a team as code owners December 6, 2024 18:18
@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/install-react-router-6/main December 6, 2024 18:30 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/install-react-router-6/main December 6, 2024 19:21 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/install-react-router-6/main December 6, 2024 19:52 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/install-react-router-6/main December 6, 2024 23:58 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/install-react-router-6/main December 7, 2024 02:30 Inactive
Copy link
Contributor

@rmessina1010 rmessina1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/install-react-router-6/main December 9, 2024 14:30 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/install-react-router-6/main December 9, 2024 21:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benefits-accredited-rep-facing Label for the OCTO Slack team #benefits-representative-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants