Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create export file for HCA helper utils #33290

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

longmd
Copy link
Contributor

@longmd longmd commented Dec 2, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

This PR creates an exports file for the Helper methods in the Health Care Application. The goal of this is to make importing these methods cleaner and simpler in the necessary sibling files.

Related issue(s)

department-of-veterans-affairs/va.gov-team#60897

Acceptance criteria

  • Helpers are successfully available for import and use

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution


// declare shared data & route attrs from the form
const { dependents: DEPENDENT_PATHS } = SHARED_PATHS;

// declare subpage configs for dependent information page
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needed moved out of the Constants file, as it created a dependency cycle after changing the imports. This is only used in this file, so it makes sense for it to just live here.

@va-vfs-bot va-vfs-bot temporarily deployed to master/longmd-60897-hca-helpers-export-file/main December 2, 2024 21:20 Inactive
Copy link
Contributor

@coope93 coope93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad you made these their own PR's and didn't add them to your others as I had initially suggested. Keeps the changes a lot more manageable and obvious 👍

@longmd longmd merged commit f915ff9 into main Dec 3, 2024
83 of 85 checks passed
@longmd longmd deleted the longmd-60897-hca-helpers-export-file branch December 3, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants