Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask VA 1425 - Fix where Veterans branch of service appears #33281

Merged

Conversation

hemeshvpatel
Copy link
Contributor

@hemeshvpatel hemeshvpatel commented Dec 2, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Refactor logic for flows
  • Update payload for about family member
  • The Ask VA team owns this and it is part of our POC

Related issue(s)

Testing done

  • Manual testing of flows

Screenshots

  • No UI changes

What areas of the site does it impact?

  • This only impacts the Ask VA form

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@hemeshvpatel hemeshvpatel self-assigned this Dec 2, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/Ask-VA-1452/Fix-where-Veterans-branch-of-service-appears-1c/main December 2, 2024 16:39 Inactive
ediiotero
ediiotero previously approved these changes Dec 2, 2024
Copy link
Contributor

@ediiotero ediiotero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@hemeshvpatel hemeshvpatel marked this pull request as ready for review December 2, 2024 16:48
@hemeshvpatel hemeshvpatel requested review from a team as code owners December 2, 2024 16:48
@hemeshvpatel hemeshvpatel marked this pull request as draft December 2, 2024 19:51
@va-vfs-bot va-vfs-bot temporarily deployed to master/Ask-VA-1452/Fix-where-Veterans-branch-of-service-appears-1c/main December 2, 2024 19:56 Inactive
Copy link
Contributor

@ediiotero ediiotero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hemeshvpatel hemeshvpatel marked this pull request as ready for review December 3, 2024 14:30
@hemeshvpatel hemeshvpatel merged commit a37badc into main Dec 3, 2024
71 of 74 checks passed
@hemeshvpatel hemeshvpatel deleted the Ask-VA-1452/Fix-where-Veterans-branch-of-service-appears-1c branch December 3, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants