Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mhv 60731 save empty message error #33279

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KyleCardwell
Copy link
Contributor

@KyleCardwell KyleCardwell commented Dec 2, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • bug: when editing a saved draft, deleting the message body but keeping only the patient signature and clicking save or send would allow saving or sending, but the message body should not be blank.
  • fix: added a check to the message body that compares it to the patient's signature. If the signature is enabled and the message body matches just the signature, throw an error.

Related issue(s)

MHV-60731 - User able to save draft when user edit the message.

User able to save the draft, when user edit the message.

Step to Reproduce

  1. Start a new Message
  2. Fill the all required field.
  3. Click on Save Draft
  4. Edit message box (Remove the whole text)
  5. Click on save draft

Issue- User able to Save the draft successfully.

User Story: As a SM user, I want to so that I can

GIVEN:

WHEN:

THEN:

Feature Flag Y/N ? N

DataDog Analytics Y/N ? N

Manual Testing Y/N ? Y-Rakesh

Automated Testing Y/N ?

Accessibility Testing Y/N ?

UCD Validation Y/N

Testing done

  • Manual testing
  • Added unit test

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Description clicking save with an empty message body allows saving clicking save with an empty message body triggers an error
Desktop Screenshot 2024-11-27 at 11 53 06 AM Screenshot 2024-11-27 at 11 51 30 AM

What areas of the site does it impact?

Va.gov - Secure Messaging

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/mhv-60731-save-empty-message-error/main December 2, 2024 15:46 Inactive
oleksii-morgun
oleksii-morgun previously approved these changes Dec 2, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/mhv-60731-save-empty-message-error/main December 2, 2024 19:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants