-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isolating 21a sub app #33262
isolating 21a sub app #33262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint is disabled
vets-website
uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.
What you can do
See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.
className="header-us-flag vads-u-margin-right--1" | ||
src="https://www.va.gov/img/tiny-usa-flag.png" | ||
/> | ||
{/* eslint-disable-next-line @department-of-veterans-affairs/prefer-button-component */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint disabled here
/> | ||
|
||
<p>An official website of the United States government</p> | ||
{/* eslint-disable-next-line @department-of-veterans-affairs/prefer-button-component, react/button-has-type */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint disabled here
} else if (profile) { | ||
content = ( | ||
<div className="va-dropdown" ref={dropdownRef}> | ||
{/* eslint-disable-next-line @department-of-veterans-affairs/prefer-button-component */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ESLint disabled here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. But I think we still need to migrate down createReduxStore
and then update the 21a README.md to explain the new situation regarding the section WIP Status and Dependency on the representative
Application
…veterans-affairs/vets-website into art/96895/isolate-21a-app
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
department-of-veterans-affairs/va.gov-team#96895
Step 1 of react-router upgrade is to fully isolate the 21a app from any libraries upgraded in the
accredited-representative-portal
application found in a parent directory.The approach is to copy components shared from the parent application into the 21a application so that we can preserve any functionality affected by the upgrade to the parent application. We also are creating a workspace with a localized
package.json
file that will ensure we stay on the current version of react-router when we upgrade the parent application.