Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isolating 21a sub app #33262

Merged
merged 19 commits into from
Dec 4, 2024
Merged

isolating 21a sub app #33262

merged 19 commits into from
Dec 4, 2024

Conversation

chumpy
Copy link
Contributor

@chumpy chumpy commented Nov 27, 2024

department-of-veterans-affairs/va.gov-team#96895

Step 1 of react-router upgrade is to fully isolate the 21a app from any libraries upgraded in the accredited-representative-portal application found in a parent directory.

The approach is to copy components shared from the parent application into the 21a application so that we can preserve any functionality affected by the upgrade to the parent application. We also are creating a workspace with a localized package.json file that will ensure we stay on the current version of react-router when we upgrade the parent application.

@chumpy chumpy self-assigned this Nov 27, 2024
@chumpy chumpy added the benefits-accredited-rep-facing Label for the OCTO Slack team #benefits-representative-facing label Nov 27, 2024
@chumpy chumpy marked this pull request as ready for review November 27, 2024 20:11
@chumpy chumpy requested review from a team as code owners November 27, 2024 20:11
Copy link

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

className="header-us-flag vads-u-margin-right--1"
src="https://www.va.gov/img/tiny-usa-flag.png"
/>
{/* eslint-disable-next-line @department-of-veterans-affairs/prefer-button-component */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

/>

<p>An official website of the United States government</p>
{/* eslint-disable-next-line @department-of-veterans-affairs/prefer-button-component, react/button-has-type */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

} else if (profile) {
content = (
<div className="va-dropdown" ref={dropdownRef}>
{/* eslint-disable-next-line @department-of-veterans-affairs/prefer-button-component */}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/isolate-21a-app/main November 27, 2024 20:23 Inactive
Copy link
Contributor

@nihil2501 nihil2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. But I think we still need to migrate down createReduxStore and then update the 21a README.md to explain the new situation regarding the section WIP Status and Dependency on the representative Application

@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/isolate-21a-app/main December 3, 2024 15:05 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/art/96895/isolate-21a-app/main December 3, 2024 15:20 Inactive
Copy link
Contributor

@nihil2501 nihil2501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chumpy chumpy merged commit e144916 into main Dec 4, 2024
73 of 74 checks passed
@chumpy chumpy deleted the art/96895/isolate-21a-app branch December 4, 2024 15:52
Thrillberg pushed a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benefits-accredited-rep-facing Label for the OCTO Slack team #benefits-representative-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants