Merge branch '96174-payment-history-back-button' of https://github.co…

…m/department-of-veterans-affairs/vets-website into 96174-payment-history-back-button

.github/PULL_REQUEST_TEMPLATE.md

@@ -69,7 +69,7 @@ _Note: This field is mandatory for UI changes (non-component work should NOT hav
 - [ ] Linting warnings have been addressed
 - [ ] Documentation has been updated ([link to documentation](#) \*if necessary)
 - [ ] Screenshot of the developed feature is added
-- [ ] [Accessibility testing](https://depo-platform-documentation.scrollhelp.site/developer-docs/wcag-2-1-success-criteria-and-foundational-testing) has been performed
+- [ ] [Accessibility testing](https://depo-platform-documentation.scrollhelp.site/collaboration-cycle/prepare-for-an-accessibility-staging-review) has been performed
 
 ### Error Handling
 

jsconfig-example.json

@@ -36,92 +36,104 @@
     "site",
 
     // Necessary action:
-    // Uncomment paths that are NOT your application(s) to improve IntelliSense performance.
-    // The more paths you exclude, the faster and more reliable IntelliSense
-    // will be for code suggestions and navigating to files from imports.
-    // Note: Changes here only affect your local development environment.
+    // You must comment out or remove your specific application to get intellisense
+    // (auto-complete, hover-hints, and go-to-definition behavior).
+    // If your application is NOT listed here, then you WILL get intellisense.
+    // The reason we exclude everything by default is because there is a
+    // limit on the number of files the IDE can index for intellisense.
+    "src/applications/_mock-form",
+    "src/applications/_mock-form-ae-design-patterns",
+    "src/applications/accredited-representative-portal",
+    "src/applications/appeals",
+    "src/applications/ask-a-question",
+    "src/applications/ask-va",
+    "src/applications/auth",
+    "src/applications/avs",
+    "src/applications/burial-poc-v6",
+    "src/applications/burials-ez",
+    "src/applications/caregivers",
+    "src/applications/check-in",
+    "src/applications/claims-status",
+    "src/applications/combined-debt-portal",
+    "src/applications/coronavirus-screener",
+    "src/applications/dhp-connected-devices",
+    "src/applications/disability-benefits",
+    "src/applications/discharge-wizard",
+    "src/applications/discover-your-benefits",
+    "src/applications/ds-playground",
+    "src/applications/ds-v3-playground",
+    "src/applications/e-folders",
+    "src/applications/edu-benefits",
+    "src/applications/education-letters",
+    "src/applications/enrollment-verification",
+    "src/applications/ezr",
+    "src/applications/facility-locator",
+    "src/applications/financial-status-report",
+    "src/applications/find-forms",
+    "src/applications/fry-dea",
+    "src/applications/gi",
+    "src/applications/hca",
+    "src/applications/health-care-supply-reordering",
+    "src/applications/income-and-asset-statement",
+    "src/applications/income-limits",
+    "src/applications/ivc-champva",
+    "src/applications/letters",
+    "src/applications/lgy",
+    "src/applications/login",
+    "src/applications/messages",
+    "src/applications/mhv",
+    "src/applications/mhv-landing-page",
+    "src/applications/mhv-medical-records",
+    "src/applications/mhv-medications",
+    "src/applications/mhv-secure-messaging",
+    "src/applications/mhv-supply-reordering",
+    "src/applications/mock-sip-form",
+    "src/applications/my-education-benefits",
+    "src/applications/office-directory",
+    "src/applications/pact-act",
+    "src/applications/pensions",
+    "src/applications/personalisation",
+    "src/applications/post-911-gib-status",
+    "src/applications/pre-need",
+    "src/applications/pre-need-integration",
+    "src/applications/proxy-rewrite",
+    "src/applications/public-outreach-materials",
+    "src/applications/rated-disabilities",
+    "src/applications/representative-appoint",
+    "src/applications/representative-search",
+    "src/applications/resources-and-support",
+    "src/applications/sah",
+    "src/applications/sco",
+    "src/applications/search",
+    "src/applications/sign-in-changes",
+    "src/applications/simple-forms",
+    "src/applications/simple-forms-forms-engine",
+    "src/applications/static-pages",
+    "src/applications/survivor-dependent-education-benefit",
+    "src/applications/terms-of-use",
+    "src/applications/third-party-app-directory",
+    "src/applications/toe",
+    "src/applications/travel-pay",
+    "src/applications/vaos",
+    "src/applications/verify",
+    "src/applications/verify-your-enrollment",
+    "src/applications/veteran-id-card",
+    "src/applications/virtual-agent",
+    "src/applications/vre",
+    "src/applications/yellow-ribbon",
 
-    // Excluded application paths
-    // "src/applications/_mock-form",
-    // "src/applications/accredited-representative-portal",
-    // "src/applications/appeals",
-    // "src/applications/ask-a-question",
-    // "src/applications/ask-va",
-    // "src/applications/auth",
-    // "src/applications/avs",
-    // "src/applications/burial-poc-v6",
-    // "src/applications/burials-ez",
-    // "src/applications/caregivers",
-    // "src/applications/check-in",
-    // "src/applications/claims-status",
-    // "src/applications/combined-debt-portal",
-    // "src/applications/coronavirus-research",
-    // "src/applications/coronavirus-screener",
-    // "src/applications/dhp-connected-devices",
-    // "src/applications/disability-benefits",
-    // "src/applications/discharge-wizard",
-    // "src/applications/ds-playground",
-    // "src/applications/ds-v3-playground",
-    // "src/applications/e-folders",
-    // "src/applications/edu-benefits",
-    // "src/applications/education-letters",
-    // "src/applications/enrollment-verification",
-    // "src/applications/ezr",
-    // "src/applications/facility-locator",
-    // "src/applications/financial-status-report",
-    // "src/applications/find-forms",
-    // "src/applications/fry-dea",
-    // "src/applications/gi",
-    // "src/applications/hca",
-    // "src/applications/income-limits",
-    // "src/applications/ivc-champva",
-    // "src/applications/letters",
-    // "src/applications/lgy",
-    // "src/applications/login",
-    // "src/applications/messages",
-    // "src/applications/mhv",
-    // "src/applications/mhv-landing-page",
-    // "src/applications/mhv-medical-records",
-    // "src/applications/mhv-medications",
-    // "src/applications/mhv-secure-messaging",
-    // "src/applications/mock-sip-form",
-    // "src/applications/my-education-benefits",
-    // "src/applications/office-directory",
-    // "src/applications/pact-act",
-    // "src/applications/pensions",
-    // "src/applications/personalisation",
-    // "src/applications/post-911-gib-status",
-    // "src/applications/pre-need",
-    // "src/applications/pre-need-integration",
-    // "src/applications/proxy-rewrite",
-    // "src/applications/public-outreach-materials",
-    // "src/applications/rated-disabilities",
-    // "src/applications/representative-appoint",
-    // "src/applications/representative-search",
-    // "src/applications/resources-and-support",
-    // "src/applications/sah",
-    // "src/applications/search",
-    // "src/applications/simple-forms",
-    // "src/applications/static-pages",
-    // "src/applications/terms-of-use",
-    // "src/applications/third-party-app-directory",
-    // "src/applications/toe",
-    // "src/applications/travel-pay",
-    // "src/applications/vaos",
-    // "src/applications/verify",
-    // "src/applications/verify-your-enrollment",
-    // "src/applications/veteran-id-card",
-    // "src/applications/virtual-agent",
-    // "src/applications/vre",
-    // "src/applications/yellow-ribbon",
-
-    // Excluded platform paths
+    // Necessary action:
+    // You must comment out or remove any of these if you want intellisense for them.
     "src/platform/landing-pages",
+    "src/platform/mhv",
     "src/platform/monitoring",
     "src/platform/pdf",
     "src/platform/polyfills",
     "src/platform/site-wide",
     "src/platform/startup",
     "src/platform/static-data",
+    "src/platform/testing",
+    "src/platform/user",
+    "src/platform/utilities"
   ]
 }

package.json

@@ -333,7 +333,8 @@
     "url-search-params-polyfill": "^8.1.1",
     "uswds": "1.6.10",
     "vanilla-lazyload": "^16.1.0",
-    "vets-json-schema": "https://github.com/department-of-veterans-affairs/vets-json-schema.git#d100b223e002a2a4eea12544a9b9d539b0d2242f"
+    "vets-json-schema": "https://github.com/department-of-veterans-affairs/vets-json-schema.git#d100b223e002a2a4eea12544a9b9d539b0d2242f",
+    "web-vitals": "^4.2.4"
   },
   "resolutions": {
     "**/lodash": "4.17.21",
@@ -397,9 +398,11 @@
       "src/platform/mhv",
       "src/applications/check-in",
       "src/applications/vaos",
-      "src/applications/claims-status"
+      "src/applications/claims-status",
+      "src/applications/accredited-representative-portal/accreditation/21a"
     ],
     "nohoist": [
+      "**/applications/accredited-representative-portal/accreditation/21a/react-router",
       "**/applications-check-in/i18next-resources-to-backend",
       "**/applications-check-in/react-i18next",
       "**/applications-claims-status/@department-of-veterans-affairs/component-library",

src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskGreen/config/form.js

@@ -4,20 +4,18 @@ import {
   yesNoUI,
 } from 'platform/forms-system/src/js/web-component-patterns';
 
-import manifest from '../../../../manifest.json';
-import content from '../../../../shared/locales/en/content.json';
-
-import { VIEW_FIELD_SCHEMA } from '../../../../utils/constants';
-
-import IntroductionPage from '../../../../shared/components/pages/IntroductionPage1010ezr';
-import ConfirmationPage from '../../../../shared/components/pages/ConfirmationPage';
-import { prefillTransformer } from '../../../../utils/helpers/prefill-transformer';
+import manifest from 'applications/_mock-form-ae-design-patterns/manifest.json';
+import { taskCompletePagePattern1 } from 'applications/_mock-form-ae-design-patterns/shared/config/taskCompletePage';
+import { GetFormHelp } from 'applications/_mock-form-ae-design-patterns/shared/components/GetFormHelp';
+import Confirmation from 'applications/_mock-form-ae-design-patterns/shared/components/pages/Confirmation';
+import IntroductionPage from 'applications/_mock-form-ae-design-patterns/shared/components/pages/IntroductionPage1010ezr';
+import content from 'applications/_mock-form-ae-design-patterns/shared/locales/en/content.json';
+import { VIEW_FIELD_SCHEMA } from 'applications/_mock-form-ae-design-patterns/utils/constants';
+import { prefillTransformer } from 'applications/_mock-form-ae-design-patterns/utils/helpers/prefill-transformer';
 
 import { EditAddress } from '../EditContactInfoTaskGreen';
-import { GetFormHelp } from '../../../../shared/components/GetFormHelp';
 import VeteranProfileInformation from '../VeteranProfileInformation';
 import { MailingAddressInfoPageTaskGreen } from '../MailingAddressInfoPageTaskGreen';
-import { taskCompletePagePattern1 } from '../../../../shared/config/taskCompletePage';
 
 export const errorMessages = {
   missingEmail: 'Add an email address to your profile',
@@ -58,16 +56,10 @@ const formConfig = {
     Promise.resolve({ attributes: { confirmationNumber: '123123123' } }),
   trackingPrefix: 'task-green',
   introduction: IntroductionPage,
-  confirmation: ConfirmationPage,
+  confirmation: Confirmation,
   formId: VA_FORM_IDS.FORM_MOCK_AE_DESIGN_PATTERNS,
   getHelp: GetFormHelp,
-  saveInProgress: {
-    // messages: {
-    //   inProgress: 'Your mock form ae design patterns benefits application (00-1234) is in progress.',
-    //   expired: 'Your saved mock form ae design patterns benefits application (00-1234) has expired. If you want to apply for mock form ae design patterns benefits, please start a new application.',
-    //   saved: 'Your mock form ae design patterns benefits application has been saved.',
-    // },
-  },
+  saveInProgress: {},
   version: 0,
   prefillTransformer,
   prefillEnabled: true,

src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskPurple/config/form.js

@@ -1,13 +1,13 @@
 import { VA_FORM_IDS } from 'platform/forms/constants';
-import profileContactInfo from './profileContactInfo';
-import { customText } from '../content/saveInProgress';
 
-import manifest from '../../../../manifest.json';
+import manifest from 'applications/_mock-form-ae-design-patterns/manifest.json';
+import Confirmation from 'applications/_mock-form-ae-design-patterns/shared/components/pages/Confirmation';
+import { GetFormHelp } from 'applications/_mock-form-ae-design-patterns/shared/components/GetFormHelp';
+import { taskCompletePagePattern1 } from 'applications/_mock-form-ae-design-patterns/shared/config/taskCompletePage';
 
+import profileContactInfo from './profileContactInfo';
+import { customText } from '../content/saveInProgress';
 import IntroductionPage from '../IntroductionPage';
-import ConfirmationPage from '../../../../shared/components/pages/ConfirmationPage';
-import { taskCompletePagePattern1 } from '../../../../shared/config/taskCompletePage';
-import { GetFormHelp } from '../GetFormHelp';
 
 const formConfig = {
   rootUrl: manifest.rootUrl,
@@ -17,7 +17,7 @@ const formConfig = {
     Promise.resolve({ attributes: { confirmationNumber: '123123123' } }),
   trackingPrefix: 'task-purple',
   introduction: IntroductionPage,
-  confirmation: ConfirmationPage,
+  confirmation: Confirmation,
   formId: VA_FORM_IDS.FORM_MOCK_AE_DESIGN_PATTERNS,
   getHelp: GetFormHelp,
   saveInProgress: {

src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskYellow/config/form.js

@@ -3,19 +3,19 @@ import {
   yesNoSchema,
   yesNoUI,
 } from 'platform/forms-system/src/js/web-component-patterns';
-import manifest from '../../../../manifest.json';
-import content from '../../../../shared/locales/en/content.json';
 
-import IntroductionPage from '../../../../shared/components/pages/IntroductionPage1010ezr';
-import ConfirmationPage from '../../../../shared/components/pages/ConfirmationPage';
-import { VIEW_FIELD_SCHEMA } from '../../../../utils/constants';
-import { taskCompletePagePattern1 } from '../../../../shared/config/taskCompletePage';
-import { prefillTransformer } from '../../../../utils/helpers/prefill-transformer';
+import manifest from 'applications/_mock-form-ae-design-patterns/manifest.json';
+import Confirmation from 'applications/_mock-form-ae-design-patterns/shared/components/pages/Confirmation';
+import { GetFormHelp } from 'applications/_mock-form-ae-design-patterns/shared/components/GetFormHelp';
+import IntroductionPage from 'applications/_mock-form-ae-design-patterns/shared/components/pages/IntroductionPage1010ezr';
+import { taskCompletePagePattern1 } from 'applications/_mock-form-ae-design-patterns/shared/config/taskCompletePage';
+import content from 'applications/_mock-form-ae-design-patterns/shared/locales/en/content.json';
+import { VIEW_FIELD_SCHEMA } from 'applications/_mock-form-ae-design-patterns/utils/constants';
+import { prefillTransformer } from 'applications/_mock-form-ae-design-patterns/utils/helpers/prefill-transformer';
 
 import VeteranProfileInformationTaskYellow from '../VeteranProfileInformationTaskYellow';
 import { MailingAddressInfoPageTaskYellow } from '../MailingAddressInfoPageTaskYellow';
 import { EditMailingAddressTaskYellow } from '../EditMailingAddressTaskYellow';
-import { GetFormHelp } from '../../../../shared/components/GetFormHelp';
 
 const formConfig = {
   rootUrl: manifest.rootUrl,
@@ -25,7 +25,7 @@ const formConfig = {
     Promise.resolve({ attributes: { confirmationNumber: '123123123' } }),
   trackingPrefix: 'task-yellow',
   introduction: IntroductionPage,
-  confirmation: ConfirmationPage,
+  confirmation: Confirmation,
   formId: VA_FORM_IDS.FORM_MOCK_AE_DESIGN_PATTERNS,
   getHelp: GetFormHelp,
   saveInProgress: {

src/applications/_mock-form-ae-design-patterns/patterns/pattern1/ezr/config/form.js

@@ -4,11 +4,15 @@ import {
   yesNoUI,
 } from 'platform/forms-system/src/js/web-component-patterns';
 
-import manifest from '../../../../manifest.json';
-import content from '../../../../shared/locales/en/content.json';
-
-import { SHARED_PATHS, VIEW_FIELD_SCHEMA } from '../../../../utils/constants';
+import manifest from 'applications/_mock-form-ae-design-patterns/manifest.json';
+import Confirmation from 'applications/_mock-form-ae-design-patterns/shared/components/pages/Confirmation';
+import IntroductionPage from 'applications/_mock-form-ae-design-patterns/shared/components/pages/IntroductionPage1010ezr';
+import content from 'applications/_mock-form-ae-design-patterns/shared/locales/en/content.json';
 
+import {
+  SHARED_PATHS,
+  VIEW_FIELD_SCHEMA,
+} from 'applications/_mock-form-ae-design-patterns/utils/constants';
 import {
   includeSpousalInformation,
   includeHouseholdInformation,
@@ -18,11 +22,9 @@ import {
   includeDependentInformation,
   includeInsuranceInformation,
   collectMedicareInformation,
-} from '../../../../utils/helpers/form-config';
-import { prefillTransformer } from '../../../../utils/helpers/prefill-transformer';
+} from 'applications/_mock-form-ae-design-patterns/utils/helpers/form-config';
+import { prefillTransformer } from 'applications/_mock-form-ae-design-patterns/utils/helpers/prefill-transformer';
 
-import IntroductionPage from '../../../../shared/components/pages/IntroductionPage1010ezr';
-import ConfirmationPage from '../../../../shared/components/pages/ConfirmationPage';
 import veteranHomeAddress from './chapters/veteranInformation/homeAddress';
 import veteranContactInformation from './chapters/veteranInformation/contactInformation';
 import maritalStatus from './chapters/householdInformation/maritalStatus';
@@ -93,7 +95,7 @@ const formConfig = {
   trackingPrefix: 'ezr',
   v3SegmentedProgressBar: true,
   introduction: IntroductionPage,
-  confirmation: ConfirmationPage,
+  confirmation: Confirmation,
   formId: VA_FORM_IDS.FORM_MOCK_AE_DESIGN_PATTERNS,
   getHelp: GetFormHelp,
   saveInProgress: {