Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-18706:Update smart date, reroll patch and test. #19059

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

anantais
Copy link
Contributor

@anantais anantais commented Aug 27, 2024

Description

Closes #18706

Testing done

  • Module updated to 4.1.5 and patch applied without error
  • Tested events content type to ensure error message still applied for recurring events that start before event date

Screenshots

Screenshot 2024-08-27 at 11 23 52 AM

QA steps

As user uid with admin

  1. Add a new event content type with a recurring date that starts before the event date.
  2. Save new event
    • Validate that event will not save and error is shown as in the above screenshot

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 27, 2024 16:05 Destroyed
@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Aug 27, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 27, 2024 16:18 Destroyed
@anantais anantais requested a review from edmund-dunn August 27, 2024 16:19
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 27, 2024 18:28 Destroyed
Copy link
Contributor

@edmund-dunn edmund-dunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@anantais anantais merged commit dbe3ed3 into main Aug 27, 2024
18 checks passed
@anantais anantais deleted the VACMS-18706-update-smart_date-module-and-reroll-patch branch August 27, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update smart_date module and reroll patch
3 participants