[Events] Hide past events on Event Detail pages so they no longer display

[jilladams]

Status

• [2024-12-02] [Fran] Added code freeze candidate and sprint tag (at Randi's excellent suggestion)
• [2024-08-07] Blocked on AP shipping Events to production, unless it becomes a fire drill.

Describe

Recurring events detail pages, "View other times for this event" panel shows all occurrences, including those in the past, with active "Add to calendar" links.

Per Michelle (7/2024) we should hide all past events from the FE, so that the Veteran/all users only see current/future events. The Government requirement to retain past events doesn't mean we need to display them; it means we need to keep them in the DB/Drupal/available if we need to report on them.

To Reproduce

Steps to reproduce the behavior:

1. Go to a recurring event with recurrences past and upcoming, e.g. https://staging.va.gov/minneapolis-health-care/events/42754/
2. Click on View other times for this event
3. See past dates

Expected behavior

All past events are hidden; only current/future events display
https://dsva.slack.com/archives/C52CL1PKQ/p1658422431625569?thread_ts=1658408251.943929&cid=C52CL1PKQ

Acceptance criteria

• All past events are hidden and no longer display

Screenshots

Current behavior

Desired behavior
All past events are hidden

Labels

(You can delete this section once it's complete)

• Issue type (red) (defaults to "Defect")
• CMS subsystem (green)
• CMS practice area (blue)
• CMS workstream (orange) (not needed for bug tickets)
• CMS-supported product (black)

CMS Team

Please check the team(s) that will do this work.

• Program
• Platform CMS Team
• Sitewide Crew
• ⭐️ Sitewide CMS
• ⭐️ Public Websites
• ⭐️ Facilities
• ⭐️ User support

[jilladams]

Don't want to add past events to calendar.
Need to validate expected behavior with Veteran research before we take action.
Would want to fold this into a future filter iteration.

[randimays]

Update here: this one is also blocked because we can't use va-icon in content-build yet for this:

Ray said they are nearly finished fixing the issue and are testing today.

[jilladams]

@FranECross do you recall what PM action was needed here?

[FranECross]

@jilladams It was to check with Ray to see if the testing was successful. Let me find my Slack message asking and I'll ping them again. I don't believe I got a response. I was thinking of a different ticket. I think I was going to create a UX ticket for Jordan, and then spin this one back up after she provided direction. I'll look follow up on this.

[jilladams]

In cross-team sync today, AP requested that unless an issue is burning, they would prefer to push it out by ~1 month. AP is hoping to move Events to production in 2 sprints. Michelle was present and signed off on pulling this out of our sprint with that in mind. Hopefully when we come back to it, we can make this change in AP templates rather than in content-build.

Removing from sprint. FYI @randimays @FranECross

[aklausmeier]

@bethpottsVADEPO FYA

[randimays]

Might be a good candidate for code freeze work if we haven't gotten to this by then.

[FranECross]

@randimays I like that idea. I added the code freeze candidate tag to the ticket.