Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang attribute on Download button sometimes empty on From detail pages #20079

Open
10 tasks
laflannery opened this issue Dec 11, 2024 · 0 comments
Open
10 tasks
Labels
a11y-defect-4 Trivial accessibility issue that should be fixed in the next 2-4 sprints accessibility Issues related to accessibility CMS frontend CMS team practice area Needs refining Issue status Public Websites Scrum team in the Sitewide crew sitewide

Comments

@laflannery
Copy link
Contributor

laflannery commented Dec 11, 2024

Description

Martha sent this over rom the latest AMP scans:

On the Download buttons on form detail pages, sometimes there is an empty lang attribute and it's being flagged in AMP. This is the tool VA looks at to determine their accessibility so it would be good to get this cleaned up.

Pages we found where the lang is empty:

Screenshot:
Image

Pages we found where the lang is en:

Screenshot:
Image

Testing & QA

Scope / Impact analysis

What, if anything, could break as a result of this change?
Engineer should assess this when approaching PR.

Roles / assignments

After functional testing, code review, accessibility review, and design review can happen in parallel.

  • Functional testing:
  • Code review:
  • Design review:
  • Accessibility review:
  • Product acceptance:

Acceptance criteria

ACs should capture expected behavior, to inform test plans. Consider devices, documentation updates including KBs, change management, and content model when applicable.

  • Download buttons do not have an empty 'lang' attribute
  • Impact analysis is filled out and QA test plan is updated accordingly
  • Does this product have an existing regression test plan?
    • Yes, link:
    • No, regression test plan will be created as part of the work / points in this ticket
@laflannery laflannery added Needs refining Issue status sitewide CMS frontend CMS team practice area Public Websites Scrum team in the Sitewide crew accessibility Issues related to accessibility a11y-defect-4 Trivial accessibility issue that should be fixed in the next 2-4 sprints labels Dec 11, 2024
@laflannery laflannery changed the title Empty lang attribute on Download button on From detail pages lang attribute on Download button sometimes empty on From detail pages Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y-defect-4 Trivial accessibility issue that should be fixed in the next 2-4 sprints accessibility Issues related to accessibility CMS frontend CMS team practice area Needs refining Issue status Public Websites Scrum team in the Sitewide crew sitewide
Projects
None yet
Development

No branches or pull requests

1 participant