-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Drupal Address Module to support Philippines addresses #19227
Comments
After some more research, it looks like the information about a given State (or "Administrative area," as they call it) in the address module comes from a dependency, the addressing PHP library. However, there's an event to which we can subscribe, the AddressEvents::SUBDIVISIONS event described in the module's documention. With that, we can add whatever subdivisions we want (including "PH"). (edited) Drupal.org |
@omahane to look at options and flesh out the ticket. Will also apply to the VBA facility in the Philippines. |
It won't block publishing Manila, but it will block future edits -- Did we decide to consider this launch blocking? Or just: asap when we understand / can get to it? |
We don't know if migrations will break this again. |
5 points is assuming an old Drupal hand does the work. If this goes to someone newer, may look more like an 8. |
A new finding related; https://dsva.slack.com/archives/C0FQSS30V/p1732570413688519
|
User Story or Problem Statement
Should an editor try to edit a Manila facility, the Address widget throws an error.
Further analysis shows that this is related to the state, being "PH" (for Philippines, which is not a state). The address from the Lighthouse Facilities API is
Should an admin save the node, the facility will save with the State subfield as blank.
Subsequently, an editor can edit and save the facility, but this leaves the state blank.
Steps for Implementation
The information about a given State (or "Administrative area," as they call it) in the address module comes from a dependency, the addressing PHP library. We can subscribe to the AddressEvents::SUBDIVISIONS event described in the module's documention. With that, we can add whatever subdivisions we want (including "PH"). (edited)
Drupal.org
Address
Provides functionality for storing, validating and displaying international postal addresses.
Acceptance Criteria
a non-US country, City, and State. If this isn't resolved in this ticket, flag for PM/DM to create a new ticket"Philippines" as a US state.The text was updated successfully, but these errors were encountered: