When iOS/Android browser mobile banners are shipped, remove the letters-mobile-cta

[jilladams]

Description

The Letters mobile CTA points any visitor to the pages where it appears to the opportunity to use the mobile app. With mobile banners in place, this will no longer be necessary.

Once remaining ioS / Android banners are shipped, we will deprecate the app

Engineering notes / background

Existing app: https://github.com/department-of-veterans-affairs/vets-website/tree/main/src/applications/static-pages/letters-mobile-cta

Related thread where DaveC clarified that this CTA should be removed after banners are live: https://dsva.slack.com/archives/C52CL1PKQ/p1695156355685709

Acceptance criteria

• Letters-mobile-cta app is deprecated including
  • vets-website code
  • vets-website codeowner rule https://github.com/department-of-veterans-affairs/vets-website/blob/main/.github/CODEOWNERS#L116
  • Drupal content for the "Get your VA letters online" section
• CMS feature toggle FEATURE_MOBILE_APP_PROMO is also removed

[jilladams]

Updated banners shipped today. If we're stable by end of this week, we could remove this feature flag anytime. @FranECross moving to stretch.

[jilladams]

We also have a CMS feature toggle that can be removed on the same timing. FE folks don't typically do that, but in this case, Randi added that flag herself, so we could opt to wrap that into these ACs as well.

[chriskim2311]

@jilladams @FranECross Before we merge these changes CAIA will need to remove this block in the CMS.

There will be changes in Content build, Vets-website, CMS repos in that order.

[jilladams]

Katherine Fung is the main editor of that page. Posed this question to her here: https://dsva.slack.com/archives/C01K37HRUAH/p1705966132181179

[jilladams]

Katherine affirmed that the React widget is ok to remove from the CMS node, however: there are several draft edits on the node and we'll need CAIA's help to sort out which of those draft updates should be published in order to publish a new revision. Katherine will need a ticket and time to prioritize that, so this ticket is blocked til that's done. Once they have a ticket up, I'll note it here so we can keep an eye. Pulling from sprint.

[jilladams]

Also: that said, there are 3 PRs in flight here:

1. VACMS-15345: Remove mobile promo banner feature flag #16966 - can go ahead and merge
2. VACMS-15345: Remove feature flag code for mobile app promo banner content-build#1883 - can merge
3. VACMS-15345: Remove letters mobile cta code vets-website#27594 - is blocked on the CAIA updates

[jilladams]

Chris noted: It's likely smart to leave the CMS feature flag in place until we get #16969 sorted out, just in case.

[jilladams]

• Blocked by Remove widget on "download VA benefits" letter page va.gov-team#74561

[jilladams]

CAIA has removed the react widget from CMS content. This ticket is unblocked.

3 PRs are up and all can be merged now that both the content update and touchscreen issue are fixed:

• VACMS-15345: Remove mobile promo banner feature flag #16966
• VACMS-15345: Remove feature flag code for mobile app promo banner content-build#1883 - has code conflicts that need to be resolved
• VACMS-15345: Remove letters mobile cta code vets-website#27594

[jilladams]

Was autoclosed by a PR. Reopening til all the related PRs get merged.

[randimays]

Reopening as this was auto-closed by a PR

[randimays]

letters-mobile-cta and mobile app promo banners validated in staging successfully 👍🏻 Will check again at prod deploy today.

[randimays]

Verified all mobile banners are still showing up as expected in production. Don't think I can test letters-mobile-cta in production since it requires a login, but all is good in staging!

[jilladams]

(Noting that for now FEATURE_MOBILE_APP_PROMO still showing up on https://prod.cms.va.gov/admin/config/system/feature_toggle bc we missed daily deploy cutoff by 1 min. But: no reason to believe this won't go live tomorrow, so reporting it done, and we can reopen / follow up if that doesn't prove out.)