Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for fetch_sensitivity_level #1747

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix for fetch_sensitivity_level #1747

merged 1 commit into from
Dec 2, 2024

Conversation

youfoundmanesh
Copy link
Contributor

Resolves #{efolder issue number} / department-of-veterans-affairs/caseflow#{caseflow issue number} / CASEFLOW-{JIRA number}

Description

Please explain the changes you made here.

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Go to ...

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue
BEFORE AFTER

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Database Changes

Only for Schema Changes

  • Timestamps (created_at, updated_at) for new tables
  • Column comments updated
  • Verify that migrate:rollback works as desired (change supported functions)
  • Query profiling performed (eyeball Rails log, check bullet and fasterer output)
  • Appropriate indexes added (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
  • Add your indexes safely (see Caseflow::Migrations
  • DB schema docs updated with make docs (after running make migrate)
  • #appeals-schema notified with summary and link to this PR
  • Any non-obvious semantics or logic useful for interpreting database data is documented at Caseflow Data Model and Dictionary

Integrations: Adding endpoints for external APIs

  • Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
    • Request: Service name, method name, input field names
    • Response: Check expected data structure
  • Update Fakes
  • Integrations impacting functionality are tested in Caseflow UAT

@youfoundmanesh youfoundmanesh merged commit e38869f into release/FY25Q1.5.0 Dec 2, 2024
3 of 4 checks passed
youfoundmanesh added a commit that referenced this pull request Dec 4, 2024
@youfoundmanesh @tradesmanhelix
@cacevesva @SanthiParakal133 @Kevma50287
Release/fy25 q1.5.0 (#1748)
db16b0e 
* APPEALS-46324: CE API User Management (#1745)

* Add Pre File Fetch Sensitivity Check (#1652)

* Add Pre File Fetch Sensitivity Check

- Verify user and veteran sensitivity levels are compatible.

- Add specs and supporting services needed to perform sensitivity
level checks.

* Implement Banner for Unauthorized Vet Access

* Restore Old Error Message Logic

* Add Specs to Cover Additional Sensitivity Cases (#1662)

* Gate VBMS Methods with Sensitivity Checks (#1665)

* Gate VBMS Methods with Sensitivity Checks

Validate user access to veteran before allowing fetch of veteran
data.

* Remove Unneeded allow Directives in Spec

* Remove Unneeded Sensitivity Checks (#1666)

* Remove Unneeded Sensitivity Checks

Checks are already handled by the sensitive_record method.

* Fix Non-Forbidden Banner Styling

* Restore Pre-Fetch Sensitivity Check Logic & Add Frontend Feature Toggle (#1667)

* Pass Sensitivity Check Feature Toggle to UI

* Restore Manifest Sensitivity Logic

* Updated ruby_claim_evidence_api gem

* Fix Missing Manifest User Causing Sensitivity Check Failures (#1675)

* Fix User Missing for BGS Sensitivity Check

- Update the manifests_controller's refresh method to use the
  find_or_create_by_user method to find a manifest. This will
  ensure that the user is set correctly for BGS calls.

- Move SensitivityLevelCheckFailure logic to the base_controller.

* Fix Misc. Issues

- Move rescue_from for BGS errors into the API V1 controller so
  its existing standard error rescue doesn't catch this exception.

- Improve manifests_controller request spec with sensitivity check
  logic.

* Use New Sensitivity Check Method (#1676)

- Use new method to check user/veteran sensitivity compatibility
  in the V2 ApplicationController.

- This will prevent the old "use BGS error to verify access" logic
  from running.

Co-authored-by: cacevesva <[email protected]>

* Update Specs to Address Failures (#1677)

* Send Veteran Number in Restart Request (#1679)

* Send Veteran Number in Restart Request

* Update Link rel Param

* Update CE API Gem (#1680)

* Update Logic for Setting Veteran ID in Request (#1681)

- Remove recently-added frontend logic for setting veteran ID in
  refresh request as it is unreliable in the way it sets the
  veteran ID.

- Update manifests_controller to set the veteran ID using the
  manifest as this is much more reliable.

* Update JSON Parsing Logic to Handle CE API Gem Changes (#1686)

- Gem now returns the JSON body of a HTTP response, so our
  response parsing code needed to be updated to handle the new
  format.

- Update the VBMS service to alert us of any API responses that
  can't be parsed so we can troubleshoot them.

* Updated ruby_claim_evidence_api

* Add current_user to SaveFilesInS3 Job (#1688)

- Since the SaveFilesInS3 job is spawned by another job, it does
  not have access to RequestStore[:current_user] which is needed
  for verifying veteran/user sensitivity compatibility.

- This PR also fixes several Rubocop violations in various files.

* add check for empty result (#1687)

* Add Script for Finding Valid UAT Testing Users (#1690)

* Kev ma/appeals 58216 time adjust (#1692)

* Adjusted UI_EXPIRY_HOURS based on deploy environment

* Adjust API HOURS

* Fix Incorrect Keyword in Script (#1693)

* Handle All Possible Errors in Script (#1694)

* Improve Script Output (#1695)

- Sort output by sensitivity level.

- Display total result count for each level.

* Updated ruby_claim_evidence_api gem with ref

* Update feature toogle to send_current_user_cred

* Update feature toogle to send_current_user_cred_to_ce_api

* Kev ma/appeals 59461 (#1701)

* Removed send_user feature flag, combined with use_ce_api

* Updated vbms service spec

* Updated manifest spec for uat expiration hours

* send user feature toggle combined with use_ce_api

* Combined with ce_api feature toggle

* Update failing rspecs

* Remove feature flag from method, wrapped method with all ce api calls

* wrap ce_api related sensitivity changes

* Fix failing specs, reverted to prior code outside of feature flag

* update manifest expiry hours to not change in test + non prod

* remove pry, reverted to previous test case

* If user is blank, return

* update front end error handling

* Linting

* Revert changes

* typo fix (#1702)

* Kev ma/appeals 58827 v2 (#1703)

* Change type_description to mapping

* Updated rspecs to handle edge case

* Updated ruby_claim_evidence_api gem

* Updated ruby_claim_evidence_api

* Deepak/appeals 59642 v1 (#1714)

* pass user info to ceapi

* Update specs

* update branch name

* fix rspec

* update claim_evidence_request method

* change ref to branch

* revert x86

---------

Co-authored-by: youfoundmanesh <[email protected]>

* Improve Claim Evidence API Error Logging (#1723)

* Add CE API Error Handler Class

* Update VBMSService and SensitivityChecker Classes with Error Handling

* Update VBMSService with CE API Error Handling

* Fix Bad Method Signature

* Fix More Spec Failures

* Fix Logging Logic Errors (#1731)

- Restore code we know is good.

- Wrap in begin/rescue blocks and handle errors there.

- Add feature toggle to ApplicationController response so frontend
  will display banners correctly.

* Update ruby_claim_evidence_api gem

* Compatible with Zeitwrek autoloader

* Deepak/appeals 65021 (#1744)

* update feature toggle for user specific

* update specs

* Fixed the code climate issues

---------

Co-authored-by: Alex Smith <[email protected]>
Co-authored-by: cacevesva <[email protected]>
Co-authored-by: SanthiParakal133 <[email protected]>
Co-authored-by: Kevma50287 <[email protected]>
Co-authored-by: Alex Smith <[email protected]>

* Fix for fetch_sensitivity_level (#1747)

---------

Co-authored-by: Alex Smith <[email protected]>
Co-authored-by: cacevesva <[email protected]>
Co-authored-by: SanthiParakal133 <[email protected]>
Co-authored-by: Kevma50287 <[email protected]>
Co-authored-by: Alex Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanthiParakal133 SanthiParakal133 SanthiParakal133 approved these changes

@Kevma50287 Kevma50287 Kevma50287 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youfoundmanesh @Kevma50287 @SanthiParakal133