-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AlecK/APPEALS-44512 - Zeitwerk Autoloader Transition #1700
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
e8432c8
to
38264e1
Compare
89c9a0f
to
7ea79db
Compare
@@ -1,17 +1,18 @@ | |||
if ENV["RAILS_ENV"] == "test" | |||
SimpleCov.start do | |||
add_filter "app/controllers/errors_controller.rb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is arranging these to be in alphabetical order necessary as a part of this work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my doing, not Alec's. Is it necessary? No. But it was a good opportunity to leave something better than I found it, and it's a low-risk change. It was also done as a separate "refactor" commit before adding the new filter.
In general, I think it's a good practice to order things lexically to make them easier to parse (especially if it's a very long list). It also helps to avoid adding duplicate entries for things (which I almost did in this case, and that prompted me to do the reordering).
Co-authored-by: Jeremy Croteau <[email protected]>
Co-authored-by: Jeremy Croteau <[email protected]>
Co-authored-by: Jeremy Croteau <[email protected]>
Co-authored-by: Jeremy Croteau <[email protected]>
Co-authored-by: Jeremy Croteau <[email protected]>
Co-authored-by: Jeremy Croteau <[email protected]>
Co-authored-by: Jeremy Croteau <[email protected]>
4749ca7
to
816a735
Compare
Resolves APPEALS-44512 - Implement Zeitwerk Autoloading for eFolder
🛑🛑🛑 BEFORE DEPLOYMENT
caseflow-commons
.caseflow
Gem reference to be updated within the Gemfile.🛑🛑🛑
Description
This PR makes the necessary changes to switch from
classic
autoloading tozeitwerk
autoloading. This is in preparation for Rails 7.0, whereclassic
autoloading will go from a deprecation warning to fully depreciated.See Rails Guides: Upgrading from Rails 6.1 to Rails 7.0
See Rails Guides: Classic to Zeitwerk HOWTO
Acceptance Criteria
bin/rails zeitwerk:check
outputs "All is good!" message.Testing Plan