Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace indiesdev/[email protected] action #2829

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Conversation

Ponnia-M
Copy link
Contributor

@Ponnia-M Ponnia-M commented Apr 4, 2024

What was the problem?[^1]

Multiple warnings with indiesdev/[email protected] action in our pipelines:

  • The following actions uses node12 which is deprecated and will be forced to run on node16: indiesdev/[email protected].
  • The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Github Actions workflows affected by warnings above:

  1. Continuous Integration (CI) => 26 warnings across various jobs
  2. CI: API Gateway integration test => 10 warnings (mostly deprecated 'set-output' command)
  3. CI: BIE Kafka End-2-End Test => 2 warnings
  4. CI: EE - EP Merge - Integration Test => 4 warnings
  5. CI: SVC BGS API integration test => 9 warnings
  6. CI: SVC BIP API integration test => 2 warnings
  7. Secrel => 6 warnings

Associated tickets or Slack threads:

How does this fix it?[^1]

Created a new action found in a public VA repo

How to test this PR

  • Run the affected workflows with my branch (update-action/ponnia) and errors related to this action don't pop up anymore.
  • Secrel => For clarity, all indiesdev/[email protected] action warnings in our Secrel workflow have been resolved. However, the current node.js 16 warnings seen here are from another action (see picture below). Based on this conversation reverting back to v5 brought back these errors.
Screenshot 2024-04-04 at 1 24 09 AM

@Ponnia-M Ponnia-M requested a review from a team as a code owner April 4, 2024 15:09
@Ponnia-M Ponnia-M requested review from tejans24 and chengjie8 April 4, 2024 15:09
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Test Results

151 tests  ±0   151 ✅ ±0   47s ⏱️ ±0s
 46 suites ±0     0 💤 ±0 
 46 files   ±0     0 ❌ ±0 

Results for commit 5960410. ± Comparison against base commit 6d22e47.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 4, 2024

JaCoCo Test Coverage

Overall Project 76.63%

There is no coverage information present for the Files changed

Copy link
Contributor

@tejans24 tejans24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding comments

helm/svc-bie-kafka/values.yaml Outdated Show resolved Hide resolved
.github/workflows/api-gateway-integration-test.yml Outdated Show resolved Hide resolved
@Ponnia-M Ponnia-M closed this Apr 8, 2024
@Ponnia-M Ponnia-M reopened this Apr 10, 2024
@Ponnia-M
Copy link
Contributor Author

@tejans24 @cheng PR has been updated and curl-action is now in public VA repo. Testing was successful for affected workflows.

@Ponnia-M Ponnia-M requested a review from tejans24 April 10, 2024 15:21
Copy link
Contributor

@chengjie8 chengjie8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ponnia-M Ponnia-M merged commit f7dca88 into develop Apr 10, 2024
5 checks passed
@Ponnia-M Ponnia-M deleted the update-action/ponnia branch April 10, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants