added migration script and code changes for action and actionResultNa… #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo Test Coverage
|
|
@chengjie8 you'll need to add pass those fields into so they data is allowed into rabbitmq channels through |
tejans24
suggested changes
Oct 4, 2023
There was a problem hiding this comment.
LG so far but we'll need to add some tests for these:
Integration test here: https://github.com/department-of-veterans-affairs/abd-vro/blob/develop/svc-bie-kafka/src/integrationTest/java/gov/va/vro/services/bie/BieKafkaApplicationTest.java#L68
These tests need to be updated.
Factory can be updated here with additional fields to use in those tests: https://github.com/department-of-veterans-affairs/abd-vro/blob/develop/shared/lib-bie-kafka/src/main/java/gov/va/vro/model/biekafka/test/BieMessagePayloadFactory.java#L13
msnwatson
approved these changes
Oct 6, 2023
| @@ -0,0 +1,3 @@ | |||
| ALTER TABLE "bie_contention_event" | |||
There was a problem hiding this comment.
note that right now, we'll have to re-deploy the vro-app with the latest db-init container to actually run these migration updates
agile-josiah
pushed a commit
that referenced
this pull request
Oct 18, 2023
Added migration script and code changes for action and actionResultNa… (#2069) * added migration script and code changes for action and actionResultName changes * added ActionName and ActionResultName to the builder method * added unit test for 2 added fields
agile-josiah
added a commit
that referenced
this pull request
Oct 19, 2023
* migrating to spring6 boot 3 * work toward spring6 * use jakarta * fix hypersistence issue * rebase and upgrade openapi gradle plugin * Changed dependencies in some files to satisfy the spring/camel/springboot upgrade * Added MockEndpoint method to replace assertMockEndpointsSatisfied(); * Removed remaining javax imports and replaced with jakarta * Updated the SecurityConfig class to use new lambda functions instead of the currently implemented method calls * Formatting change * More test fixes to update dependencies for the spring upgrade - Changed postgres dialect for tests to PostgreSQLDialect - Changed camel-rabbitmq version to spring...-rabbitmq - Bumped the h2_version, and hibernate_types_version - Updated various jakarta class dependencies - Added DuplicatesStrategy.EXCLUDE to bootJar tasks to prevent xample-workflows tests from failing TODO: Change GenericGenerator strategy to type in the Persistence models * Added test-code java step to test-python * Updated mocks api code to include jakarta spring changes. - Updated the jsonwebtoken:jjwt version - Changed the jwtprops secret to a secret key based on the HS256 signature algo - * Change HttpStatus to match the exception type statusCode * More Jwt test fixes - Updates the props secret to use a key for the SignatureAlgorithm.HS256 * Spotless Apply check * Trying new AntPathRequestMatchers to manage securityConfig requests to the api * added actuator urls to spring security request matcher * SpotlessApply on mock-bip-claims/ce SecurityConfig * Testing if removing SecurityFilterBean fixes 401 issues in pipeline tests. * Changed to use the new springdoc libraries for vro-app and other openapi usage. * reverts the @EnableWebSecurity removal test * Changed to use the new springdoc libraries for vro-app and other openapi usage. * reverts the @EnableWebSecurity removal test * Adding version number to openapi dependencies * testing an add to v3_urls * adding more dependency changes to springdoc dependencies * Testing adding securityMatcher() to authorizeHttpRequests(). * Experimenting permitAll() * Experimenting adding the requestMatchers back * Experimenting with removing anyRequest() * Testing more spring stuff with securityMatchers->requestmatching * Add antPathMatchers to the requestMatchers fields on authorizeHttpRequests. This should help define our routes so they are clearly using AntMatchers. * Adding more camel springboot rabbitmq dependencies * Updates to camel routes * updated endpoint prefixes to be spring-rabbitmq: * change the queue -> queues * added some camel config formatting/additions * Added CamelQueue and TopicExchange Beans so they are explicitly created by the app. * Add Queue and FanoutExchange beans for the bie-events-contention queues. * Change durable flag to true on all queues * Tweaked some fields so they don't conflict with existing definitions. * Was deleted somehow during previous merge (@cheng) Added migration script and code changes for action and actionResultNa… (#2069) * added migration script and code changes for action and actionResultName changes * added ActionName and ActionResultName to the builder method * added unit test for 2 added fields * Bump version to where they are on develop to address comments. * Fix formatting * Change assertIsSatisfied to the new method * Change assertIsSatisfied to the new method * Formatting Changes * Chengjie8/issue 230 (#2112) * update tomcat embed core library version * more library version upgrades * fix minor format issue * Automated commit: Unpin versions of updated images * update uri version in bgs service * update to 10.1.14' * upgrade lib version --------- Co-authored-by: VRO Machine User <[email protected]> * revert back the gem upgrade --------- Co-authored-by: josiahjones <[email protected]> Co-authored-by: Josiah Jones <[email protected]> Co-authored-by: Chengjie Yin <[email protected]> Co-authored-by: VRO Machine User <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Associated tickets or Slack threads:
How does this fix it?1
How to test this PR
Footnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩