Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use relative imports where possible #110

Merged
merged 20 commits into from
Nov 28, 2023
Merged

fix: use relative imports where possible #110

merged 20 commits into from
Nov 28, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Nov 28, 2023 •
edited
Loading

Closes #109

@iuioiua iuioiua marked this pull request as ready for review November 28, 2023 23:18
@iuioiua iuioiua marked this pull request as draft November 28, 2023 23:34
dsherret
dsherret approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret marked this pull request as ready for review November 28, 2023 23:51
@dsherret dsherret merged commit 2f356fb into denoland:main Nov 28, 2023
4 checks passed
@iuioiua iuioiua deleted the relative-imports branch November 28, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import Loader and cacheToLocalDir using relative path
2 participants
@iuioiua @dsherret