-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add problem matchers for deno lint
#62
Conversation
problem-matchers.json
Outdated
"owner": "deno-lint", | ||
"pattern": [ | ||
{ | ||
"regexp": "^(?:\\x1B\\[[0-9;]*[a-zA-Z])*(warning|warn|error)(?:\\[(\\S*)\\])?(?:\\x1B\\[[0-9;]*[a-zA-Z])*: (.*?)(?:\\x1B\\[[0-9;]*[a-zA-Z])*$", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(warning|warn|error)
I know that there is at least an error
in the severity of deno lint
, but I am not exactly sure what other severities exist. If anyone has exact information, please let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems very useful to have included bundled into the denoland/setup-deno
action. There's been no activity for half a year now. Any chance for review from the Deno team, @dsherret?
problem-matchers.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add deno-
as prefix to this file (deno-problem-matchers.json
), to make it more consistent with examples from actions/toolkit?
3c4b587
to
b6cd600
Compare
6ec544a
to
83b8948
Compare
Hmmm, it seems to have stopped working properly now. Perhaps the output format of edit: It seems that the output of I experimented with the modified version and it worked well, so it probably should not be a problem now. |
83b8948
to
fe699ef
Compare
fe699ef
to
a2690b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for the delay on this. Will cut a release of setup-deno during the day
Related to:
I did not add a matcher for
deno fmt --check
this time, because I thought its output lacked tinformation to be used by problem matchers and could not be handled well.I have tried this feature on my own sample project and confirmed that it works well like this:
The real example is here: