Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lsp: allow "lint-only" mode #15956

Closed
mjgerace opened this issue Sep 19, 2022 · 2 comments
Closed

lsp: allow "lint-only" mode #15956

mjgerace opened this issue Sep 19, 2022 · 2 comments
Labels
lsp related to the language server suggestion suggestions for new features (yet to be agreed)

Comments

@mjgerace
Copy link

Is your feature request related to a problem? Please describe.
It's no secret that deno_lint is fast. Like, much, much faster than eslint. As such (and as the deno_lint roadmap heads toward eslint plugin compatibility and autofix), deno will see an increasing number of users and companies adopt deno lint for their linting solution, whether they use node, deno, or any other runtime.

Obviously, running lint in CI is nice, but most users want LSP integration, so that they can see lint issues as they write code.

Describe the solution you'd like
If this extension/lsp were to enable users to run the deno lsp purely for linting, without disabling normal typescript language features, and without enabling any other deno lsp features, we could have a hybrid world where users who use node, bun, etc, could use deno lint to great success.

This would increase adoption and awareness of deno tooling, and make other engineers happy.

Essentially, I wish the deno vscode extension would let us do "deno.enable": false, "deno.lint": true. In this sense, we get the linting features of the deno lsp without turning off visual studio code typescript language features.

Please consider this request! Let me know if I can provide any further information.

@kitsonk kitsonk transferred this issue from denoland/vscode_deno Sep 19, 2022
@kitsonk kitsonk changed the title Allow "lint-only" mode lsp: allow "lint-only" mode Sep 19, 2022
@kitsonk kitsonk added suggestion suggestions for new features (yet to be agreed) lsp related to the language server labels Sep 19, 2022
@kitsonk
Copy link
Contributor

kitsonk commented Sep 19, 2022

This is something that would need to be addressed in the Deno CLI's language server primarily, so I have moved it here.

@kitsonk
Copy link
Contributor

kitsonk commented Sep 29, 2022

Actually, forgot, this is really a duplicate of denoland/vscode_deno#622

@kitsonk kitsonk closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lsp related to the language server suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Development

No branches or pull requests

2 participants