removes old archives from client cache dir #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessicaTegner
force-pushed
the
issue92
branch
6 times, most recently
from
b0e7dd4 to
37f329f
Compare
JessicaTegner
force-pushed
the
issue92
branch
from
37f329f to
49faa20
Compare
dennisvang
requested changes
Nov 29, 2024
| @@ -184,6 +184,13 @@ def check_for_updates( | |||
| sys.exit() | |||
| return None | |||
| # check for new target files (archives and patches) | |||
| # look through all files in self.current_archive_local_path.parent, and remove all that is not self.current_archive_local_path | |||
| # this is to save space | |||
| for file in self.current_archive_local_path.parent.iterdir(): | |||
There was a problem hiding this comment.
Suggested change
| for file in self.current_archive_local_path.parent.iterdir(): | |
| for path in self.current_archive_local_path.parent.iterdir(): |
for consistency
| for file in self.current_archive_local_path.parent.iterdir(): | ||
| metadata_for_file = TargetMeta.parse_filename(file.name) | ||
| logger.debug(f'checking {metadata_for_file}') | ||
| if TargetMeta(name=metadata_for_file["name"], version=metadata_for_file["version"], is_archive=metadata_for_file["suffix"]) < self.current_archive: |
There was a problem hiding this comment.
TargetMeta can be instantiated directly from the file path, so no need for the parse_filename() call.
Line 66 in 473045f
To be safe, I would remove any and all .patch files and .tar.gz files not equal to current_archive.
It would be nice if this could be placed in a separate method, e.g. clean_cache(), which is then called from here.
The clean_cache() method would need a test as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This loops through all files in "self.current_archive_local_path.parent" and deletes all files that are not equal to "self.current_archive_local_path".
Fixes #92