Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt update-cycle test scripts to macOS #24

Open
dennisvang opened this issue Nov 29, 2023 · 5 comments · May be fixed by #26
Open

Adapt update-cycle test scripts to macOS #24

dennisvang opened this issue Nov 29, 2023 · 5 comments · May be fixed by #26
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@dennisvang
Copy link
Owner

Powershell also runs on macOs (and Linux), so we should adapt the test_update_cycle.ps1 script and the github workflow to work on macOS as well.

@dennisvang dennisvang self-assigned this Nov 29, 2023
@dennisvang dennisvang added the enhancement New feature or request label Nov 29, 2023
@Moosems
Copy link

Moosems commented Nov 29, 2023

The create_pyinstaller_bundle_mac.sh script (or rather the spec file) didnt work:

Moosems-MacBook-Pro:tufup-example Moosems$ chmod +x '/Users/Moosems/Desktop/tufup-example/create_pyinstaller_bundle_mac.sh'
Moosems-MacBook-Pro:tufup-example Moosems$ '/Users/Moosems/Desktop/tufup-example/create_pyinstaller_bundle_mac.sh'
639 INFO: PyInstaller: 5.13.2
640 INFO: Python: 3.11.3
659 INFO: Platform: macOS-10.14.6-x86_64-i386-64bit
664 INFO: Removing temporary files and cleaning cache in /Users/Moosems/Library/Application Support/pyinstaller
774 INFO: Extending PYTHONPATH with paths
['/Users/Moosems/Desktop/tufup-example/src']
pygame 2.5.1 (SDL 2.28.2, Python 3.11.3)
Hello from the pygame community. https://www.pygame.org/contribute.html
1693 INFO: Appending 'datas' from .spec
Unable to find "/Users/Moosems/Desktop/tufup-example/temp_my_app/repository/metadata/root.json" when adding binary and data files.

@dennisvang
Copy link
Owner Author

dennisvang commented Nov 29, 2023

@Moosems Sorry, I forgot to mention that you need to run the repo_init.py script first. It is mentioned in the README though.

@Moosems
Copy link

Moosems commented Nov 29, 2023

Then I get:

Traceback (most recent call last):
  File "/Users/Moosems/Desktop/tufup-example/repo_init.py", line 5, in <module>
    from myapp.settings import APP_NAME
ModuleNotFoundError: No module named 'myapp'

@dennisvang
Copy link
Owner Author

dennisvang commented Nov 29, 2023

@Moosems You'll need to add the tufup-example/src dir to your PYTHONPATH.

For example, in bash, something like:

export PYTHONPATH="$PYTHONPATH:/Users/Moosems/Desktop/tufup-example/src"

(related to #4)

@dennisvang dennisvang added the help wanted Extra attention is needed label Apr 4, 2024
@dennisvang
Copy link
Owner Author

As I don't have access to a mac, it's a bit difficult to test #26 locally. If someone could try it on a mac, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants