Skip to content
This repository has been archived by the owner on Oct 8, 2022. It is now read-only.

calcTotalValueLockedForTerm param should be tokenInfo not lists #41

Open
jrhea opened this issue Oct 25, 2021 · 1 comment
Open

calcTotalValueLockedForTerm param should be tokenInfo not lists #41

jrhea opened this issue Oct 25, 2021 · 1 comment

Comments

@jrhea
Copy link
Contributor

jrhea commented Oct 25, 2021

it might be better for this method to accept the tokenInfos need rather than passing the list and having it search.

export async function calcTotalValueLockedForTerm(
  trancheInfo: PrincipalTokenInfo,
  balancerVaultAddress: string,
  ptPoolInfo: PoolInfo,
  ytPoolInfo: PoolInfo,
  // etc etc
  assetProxyTokenInfo: AssetProxyTokenInfo,
  signerOrProvider: Signer | Provider
): Promise<Money> {

Originally posted by @jrhea in #37 (comment)

@jrhea jrhea changed the title it might be better for this method to accept the tokenInfos need rather than passing the list and having it search. calcTotalValueLockedForTerm param should be tokenInfo not lists Oct 25, 2021
@51bitquant
Copy link

Yes, that will be more readable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants