Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep line breaks in quoted messages #4356

Closed
wants to merge 1 commit into from
Closed

Conversation

nicodh
Copy link
Contributor

@nicodh nicodh commented Nov 25, 2024

resolves #4354

@nicodh nicodh requested a review from WofWca November 25, 2024 20:51
Copy link
Collaborator

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message references wrong the issue. Needs to be #4354.

I didn't test this yet, but is it not possible to achieve with the white-space CSS property?

@nicodh
Copy link
Contributor Author

nicodh commented Nov 26, 2024

The commit message references wrong the issue. Needs to be #4354.

It IS #4354 - maybe you mixed it up with the PR number #4356 ?

I didn't test this yet, but is it not possible to achieve with the white-space CSS property?

No because without the conversion of Linebreaks to {\n} there is no linebreak white-space

@WofWca
Copy link
Collaborator

WofWca commented Nov 26, 2024

It IS #4354 - maybe you mixed it up with the PR number #4356 ?

Sorry, I didn't mention that I edited MR description, but the commit message still references the wrong issue.

@nicodh
Copy link
Contributor Author

nicodh commented Nov 26, 2024

Ok, fixed the commit message

@nicodh nicodh requested a review from WofWca November 27, 2024 10:31
WofWca added a commit that referenced this pull request Nov 27, 2024
Closes #4354.
Supersedes #4356.

The bug was introduced in 78fef8b.
WofWca added a commit that referenced this pull request Nov 27, 2024
Closes #4354.
Supersedes #4356.

The bug was introduced in 78fef8b.

Co-authored-by: Nico de Haen <[email protected]>
WofWca added a commit that referenced this pull request Nov 27, 2024
Closes #4354.
Supersedes #4356.

The bug was introduced in 78fef8b.

Co-authored-by: Nico de Haen <[email protected]>
@nicodh nicodh closed this Nov 27, 2024
@nicodh
Copy link
Contributor Author

nicodh commented Nov 27, 2024

No need to use different functions here

@nicodh nicodh deleted the fix-4354-quote-linebreaks branch November 27, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lineends are lost in quotes
2 participants