Skip to content

Commit

Permalink
style: ugly reactions positioning on image msgs
Browse files Browse the repository at this point in the history
Closes #4235

The issue probably existed ever since the reactions were added
in the first place #2964,
but it got worse after the removal of margin addition
when adding a reaction (60e52c7).

This commit should make things simpler
because all positioning-related stuff
is only done in `message/styles.module.scss`.
  • Loading branch information
WofWca authored and Simon-Laux committed Oct 22, 2024
1 parent a698e23 commit 2dcb34c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
- improve accessibility a little #4133
- fix "Mark All As Read" in account menu mark also archived chats as read
- use authname instead of displayname for vcard filename #4233
- ugly positioning of reactions on image-only messages #4237


<a id="1_46_8"></a>
Expand Down
4 changes: 0 additions & 4 deletions packages/frontend/scss/message/_metadata.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@
margin-bottom: -3px;

&.with-image-no-caption {
position: absolute;
right: 5px;
bottom: 5px;
float: right;
padding: 4px 10px 1px 10px;
margin: 0;
background-color: #0000008f;
Expand Down
4 changes: 2 additions & 2 deletions packages/frontend/src/components/message/styles.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@
// transition: margin-bottom ease-out $reaction-transition-duration;

&.onlyMedia {
bottom: 0;
bottom: 5px;
left: 0;
margin-left: 10px;
position: absolute;
right: 0;
right: 5px;
}

// &.withReactionsNoText {
Expand Down

0 comments on commit 2dcb34c

Please sign in to comment.