Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching RedisConnection to ConnectionInterface #9

Open
szepeviktor opened this issue Jul 19, 2020 · 0 comments
Open

Matching RedisConnection to ConnectionInterface #9

szepeviktor opened this issue Jul 19, 2020 · 0 comments

Comments

@szepeviktor
Copy link
Contributor

What do you think about these?

diff --git a/src/WP_Queue/Connections/RedisConnection.php b/src/WP_Queue/Connections/RedisConnection.php
index 346a348..28a72de 100644
--- a/src/WP_Queue/Connections/RedisConnection.php
+++ b/src/WP_Queue/Connections/RedisConnection.php
@@ -16,7 +16,7 @@ class RedisConnection implements ConnectionInterface {
         * @return bool|int
         */
        public function push( Job $job, $delay = 0 ) {
-               //
+               return true;
        }

        /**
@@ -25,7 +25,7 @@ class RedisConnection implements ConnectionInterface {
         * @return bool|Job
         */
        public function pop() {
-               //
+               return true;
        }

        /**
@@ -55,7 +55,7 @@ class RedisConnection implements ConnectionInterface {
         * @return bool
         */
        public function failure( $job, Exception $exception ) {
-               //
+               return true;
        }

        /**
@@ -64,7 +64,7 @@ class RedisConnection implements ConnectionInterface {
         * @return int
         */
        public function jobs() {
-               //
+               return 0;
        }

        /**
@@ -73,7 +73,7 @@ class RedisConnection implements ConnectionInterface {
         * @return int
         */
        public function failed_jobs() {
-               //
+               return 0;
        }

 }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant