Gnome 45 #215
Closed
Gnome 45 #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…od on extension.js
DisDis
reviewed
Oct 1, 2023
| import * as Util from 'resource:///org/gnome/shell/misc/util.js'; | ||
| import * as Config from 'resource:///org/gnome/shell/misc/config.js'; | ||
| import Gettext from 'gettext'; | ||
| const _ = Gettext.domain('gnome-shell-extension-cpupower'); |
There was a problem hiding this comment.
Use https://gjs.guide/extensions/development/translations.html#initializing-translations
import {Extension, gettext as _, ngettext, pgettext} from 'resource:///org/gnome/shell/extensions/extension.js';
and
initTranslations()
in body
|
Is this working correctly as nobody seems to care |
No, it doesn't. I left Linux, and have no plans to work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still missing some files to upgrade for ESM, fixes: #214