Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeaviateDocumentStore Timeout Config Documentation Misleading #7378

Closed
baldpanda opened this issue Mar 18, 2024 · 2 comments
Closed

WeaviateDocumentStore Timeout Config Documentation Misleading #7378

baldpanda opened this issue Mar 18, 2024 · 2 comments
Labels
type:documentation Improvements on the docs

Comments

@baldpanda
Copy link

Describe the bug
The documentation for the WeaviateDocumentStore timeout_config isn't the same as the documentation provided in the Weaviate documentation for the Weaviate client. I think instead of (retries, time out seconds) it should be (connect timeout, read timeout).

Error message
NA

Expected behavior
NA

Additional context

To Reproduce
NA

FAQ Check

System:
NA

@anakin87
Copy link
Member

I had a quick look and think you are right.
This is related to Haystack 1.x, where Weaviate was an optional dependency.

In Haystack 2.0, it is a separate integration: https://docs.haystack.deepset.ai/docs/weaviatedocumentstore

If you want to open a PR against the v1.x branch to fix this docstring, you are welcome!

@anakin87
Copy link
Member

done in #7380.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements on the docs
Projects
None yet
Development

No branches or pull requests

2 participants