Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Existing pipelines missing filter_policy in yaml files will break when loading #894

Closed
sjrl opened this issue Jul 15, 2024 · 1 comment · Fixed by #895, #896, #897, #898 or #899
Closed

bug: Existing pipelines missing filter_policy in yaml files will break when loading #894

sjrl opened this issue Jul 15, 2024 · 1 comment · Fixed by #895, #896, #897, #898 or #899
Labels
bug Something isn't working

Comments

@sjrl
Copy link
Contributor

sjrl commented Jul 15, 2024

Describe the bug
Recently FilterPolicy was added in a series of PRs to Retrievers of each Document Store.

However, it was added in such a way that is required to specify a value in the yaml file even though the init methods of the Retrievers have a default value for FilterPolicy.

data["init_parameters"]["filter_policy"] = FilterPolicy.from_str(data["init_parameters"]["filter_policy"])

To Reproduce
Try loading a pipeline from a yaml file with a OpenSearchEmbeddingRetriever without specifying filter_policy. This is an issue with all Retrievers all doc stores.

Describe your environment (please complete the following information):

  • OS: [e.g. iOS]
  • Haystack version: 2.3
  • Integration version: opensearch-haystack 0.8.0
@sjrl sjrl added the bug Something isn't working label Jul 15, 2024
@wochinge
Copy link
Contributor

Big thanks for the catch @sjrl !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants