Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nvidia Components can't access API Keys #745

Closed
TuanaCelik opened this issue May 22, 2024 · 2 comments
Closed

Nvidia Components can't access API Keys #745

TuanaCelik opened this issue May 22, 2024 · 2 comments
Assignees
Labels
bug Something isn't working integration:nvidia P1

Comments

@TuanaCelik
Copy link
Contributor

Describe the bug
@shadeMe and @silvanocerza - here's the reason for our dirty fix for nvidia integration today, as well as steps to reproduce.

Prior info:

  • I did not have this bug locally, however, the minute I setup a dockerized environment and deployed the pipeline with hayhooks I did.
  • This issue is across all NVIDIA components
  • I was using the hosted models for which you can get API keys here
  • All the code you need is public, including docker compose files etc in our nvidia-haystack repo
  • I provided a dirty fix and we released nvidia-haystack 0.0.3 to ublock our work with them. The PR that was merged is Update _nim_backend.py #744

The issue is that although NVIDIA_API_KEY env var is available, and although we've confirmed it works locally, when we deploy rag.yaml (you can simplify it by replacing retrieval with link content fetching), we will get a 401 unauthorized error seemingly coming from the nim backend components.

To Reproduce
Cone the repo and:

  • docker-compose up
  • pip install nvidia-haystack==0.0.2 (old version which caused the issue)
  • (If you're gonna use the same rag with Qdrant, also pip install qdrant-haystack)
  • (If your're gonna use the same rag with Qdrant: python indexing.py)
  • hayhooks deploy rag.yaml
  • Try runninng a query..
@TuanaCelik TuanaCelik added the bug Something isn't working label May 22, 2024
@shadeMe shadeMe added the P2 label Jun 10, 2024
@TuanaCelik
Copy link
Contributor Author

Update and more context if anyone needs it.
I created a quick fix to the Nvidia NIM components to unblock the work with Nvidia and out co-authored article.

The issue that I lay out above about the api keys still stand, and you should still be able to reproduce it with hayhooks/docker using the same repository.

The point is, that this was a simple fix that I noticed and Massi agreed that the issue stemmed from the fact that there were no default api key environment variables provided in some components. But this might not be the right fix. If you decide that the fix was ok, then this issue can be closed, if not, someone should reproduce the steps above to see why things go wrong and provide an alternative fix.

@silvanocerza
Copy link
Contributor

Just tested, can't reproduce.
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working integration:nvidia P1
Projects
None yet
Development

No branches or pull requests

4 participants