Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add return_embedding parameter to OpenSearchEmbeddingRetriever #657

Closed
nickprock opened this issue Apr 12, 2024 · 2 comments · Fixed by #784
Closed

add return_embedding parameter to OpenSearchEmbeddingRetriever #657

nickprock opened this issue Apr 12, 2024 · 2 comments · Fixed by #784
Labels
feature request Ideas to improve an integration integration:opensearch P2

Comments

@nickprock
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In InMemoryEmbeddingRetriever there is the parameter return_embedding that returns also embedding in Document, with OpenSearchEmbeddingRetriever I must recalculates embeddings after the retrieve step.

@nickprock nickprock added the feature request Ideas to improve an integration label Apr 12, 2024
@masci masci added P1 P2 and removed P1 labels May 10, 2024
@wochinge
Copy link
Contributor

This would be actually helpful for us on deepset cloud side as well. No need to pull out the embeddings for us (basically just unneeded network traffic)

@nickprock
Copy link
Contributor Author

Thanks @ArzelaAscoIi 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Ideas to improve an integration integration:opensearch P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants