Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fastembed: progress_bar is not used #554

Closed
anakin87 opened this issue Mar 6, 2024 · 0 comments · Fixed by #558
Closed

Fastembed: progress_bar is not used #554

anakin87 opened this issue Mar 6, 2024 · 0 comments · Fixed by #558
Labels
bug Something isn't working contributions wanted! Looking for external contributions good first issue Good for newcomers integration:fastembed

Comments

@anakin87
Copy link
Member

anakin87 commented Mar 6, 2024 •
edited
Loading

Describe the bug
While present as an attribute, progress_bar is not used:
the progress bar is never shown.
The parameter is passed to the backed that ignores it.

Proposed solution
Make it work in the Embedders or in the backend using tqdm as done for example for the OpenAI Document Embedder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working contributions wanted! Looking for external contributions good first issue Good for newcomers integration:fastembed
Projects
Haystack - Contributions wanted
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improvements to FastEmbed integration deepset-ai/haystack-core-integrations
1 participant
@anakin87