Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update all generator integrations to use new generic callable (de)serializers for their callback handlers #415

Closed
vblagoje opened this issue Feb 14, 2024 · 3 comments
Assignees
Labels
feature request Ideas to improve an integration P1

Comments

@vblagoje
Copy link
Member

We have migrated all the (de)serialize callback handlers in Haystack 2.x to use the new generic utils methods serialize_callable and deserialize_callable. Now, we need to do that for all generators in haystack-core-integrations. The best time to migrate these will likely be after the next Haystack beta is released.

@vblagoje vblagoje added the feature request Ideas to improve an integration label Feb 14, 2024
@masci masci added the P1 label Feb 16, 2024
@ZanSara
Copy link
Contributor

ZanSara commented Feb 20, 2024

Work to be done:

All others don't need any change.

@masci
Copy link
Contributor

masci commented Feb 21, 2024

@ZanSara I think the two linked PRs do something different - this issue was open to keep track of the changes needed after replacing haystack.components.generators.utils.serialize_callback_handler in main with haystack.utils.callable_serialization.serialize_callable. The course of action I imagine would involve a new beta release to ship serialize_callback_handler and change the integrations (or merging your current PRs but change the integration again later after we release the change). In that sense, you should add ollama to the list of integrations that we need to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Ideas to improve an integration P1
Projects
None yet
Development

No branches or pull requests

3 participants